Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

node name with namespace #146

Merged
merged 1 commit into from
Sep 6, 2018
Merged

node name with namespace #146

merged 1 commit into from
Sep 6, 2018

Conversation

dirk-thomas
Copy link
Member

Follow up of ros2/rmw#142.

Proposed to replace #143 and #144.

Fixes #105, fixes #128 and fixes ros2/ros2#569.

@dirk-thomas dirk-thomas added the in review Waiting for review (Kanban column) label Sep 6, 2018
@dirk-thomas dirk-thomas self-assigned this Sep 6, 2018
@dirk-thomas dirk-thomas merged commit ce9077f into master Sep 6, 2018
@dirk-thomas dirk-thomas deleted the node_name_with_namespace branch September 6, 2018 20:58
@dirk-thomas dirk-thomas removed the in review Waiting for review (Kanban column) label Sep 6, 2018
esteve pushed a commit to esteve/ros2cli that referenced this pull request Dec 16, 2022
* Fix test_node_frontend

Fix ros2#145

1. Make test names more intelligible by not parameterizing on a crazy long string
2. Don't leak StringIO objects
Signed-off-by: Dan Rose <dan@digilabs.io>

* Some renamings and perform the same fixes on test_push_ros_namespace_frontend

Signed-off-by: Dan Rose <dan@digilabs.io>

* Remove incorrect docstring

Signed-off-by: Dan Rose <dan@digilabs.io>

* Add copyright for files with contributions

Signed-off-by: Dan Rose <dan@digilabs.io>

* Fix formatting

Signed-off-by: Dan Rose <dan@digilabs.io>

* Fix copyrights

Signed-off-by: Dan Rose <dan@digilabs.io>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants