Request for backport of 428 to eloquent #439
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Tully Foote <tfoote@osrfoundation.org>
tfoote
approved these changes
Jan 24, 2020
|
Since binary packages for Eloquent Patch Release 1 have already been rolled and are being tested, this won't make it in there, but I don't see any problem with getting it in the next one. CC: @nuclearsandwich for dashing. |
If you can open the Dashing backport @mikaelarguedas we can do both in parallel. |
Sure thing, #442 |
|
@tfoote @mjcarroll What is the status of this PR? |
mjcarroll
approved these changes
Jan 29, 2020
|
Good to go, lost track of it in the patch release last week. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently the generated packages fail to pass rosdep making them hard to reuse.
Ideally this would be backported and released in Dashing as well.
Note: The tutorials refering to this invalid builtool dependency explicitly would need to be updated. That'll make them valid when used with the nightly archives as well that don't list that dependency.