Add interface definitions and update ros2interface show tests to use them
#547
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
audrow
force-pushed
the
audrow/remove-depend-on-builtin-interface
branch
from
53b0ab2
to
b1eb6b8
Compare
Please keep that unrelated change in a separate PR since the title of this PR doesn't give any hint that the patch also addresses that. Both changes might also be considered individually for backporting. |
|
Sounds good. I'll split them up and open a separate PR for the bug fix, as well as consider them separately for backporting. |
|
I made the bug fix its own PR in #548. After it's merged in, I'll update this PR to build off of those changes (since the updated tests assume that the bug is fixed). |
audrow
force-pushed
the
audrow/remove-depend-on-builtin-interface
branch
2 times, most recently
from
167a5c2
to
6931c1d
Compare
audrow
changed the title
builtin_interfacesros2interface show tests to use them
audrow
force-pushed
the
audrow/remove-depend-on-builtin-interface
branch
from
4cb8dcf
to
6931c1d
Compare
|
This set of PRs seems to pass CI without breaking downstream packages. I'll run the rest of CI once these PRs are reviewed. |
Signed-off-by: Audrow <audrow.nash@gmail.com>
audrow
force-pushed
the
audrow/remove-depend-on-builtin-interface
branch
2 times, most recently
from
d7fa446
to
f153181
Compare
|
Closed in favor of #579. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #541.