Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Switch ros2 doctor to using psutil for network checks. #687

Merged
merged 1 commit into from
Jan 24, 2022
Merged

Switch ros2 doctor to using psutil for network checks. #687

merged 1 commit into from
Jan 24, 2022

Commits on Jan 19, 2022

  1. Switch ros2 doctor to using psutil for network checks. 

    ifcfg has a couple of different problems.  The first is that
the code literally calls 'ifconfig' and parses the output.  While
this generally works, it is pretty ugly.  For those reasons,
Debian has specifically excluded it.

Instead, switch to psutil to get information about the network
interfaces on the system (at least, on POSIX).  This gets us
all of the information we had before, but using ioctl's instead.

Note that we can't actually get any flags from psutil at the
moment.  There is a PR open upstream to get this information,
but since it is not going to be available soon we implement
the equivalent thing in Python by using fcntl.ioctl.

Signed-off-by: Chris Lalancette <clalancette@openrobotics.org>
    @clalancette
    clalancette committed Jan 19, 2022
    Configuration menu
    Copy the full SHA
    e4b540a View commit details
    Browse the repository at this point in the history