Add on play message callbacks to the rosbag2::Player class
#1004
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Added new API add_on_play_message_pre_callback(const play_msg_callback_t & callback) add_on_play_message_post_callback(const play_msg_callback_t & callback) delete_on_play_message_callback(const callback_handle_t & handle) Signed-off-by: Michael Orlov <michael.orlov@apex.ai>
MichaelOrlov
requested review from
gbiggs,
hidmic and
emersonknapp
and removed request for
a team
|
@gbiggs @hidmic @emersonknapp Kindly ping for review. |
gbiggs
approved these changes
Jun 1, 2022
|
CI:
|
Signed-off-by: Michael Orlov <michael.orlov@apex.ai>
|
@gbiggs I pushed new commit to fix warnings on Windows build. |
gbiggs
approved these changes
Jun 2, 2022
|
Rerunning Windows CI: |
Signed-off-by: Michael Orlov <michael.orlov@apex.ai>
gbiggs
approved these changes
Jun 2, 2022
|
LGTM; ready to merge. |
delete-merged-branch
bot
deleted the
morlov/add-callbacks-before-after-message-play
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Address #1003
Added new API:
add_on_play_message_pre_callback(const play_msg_callback_t & callback)
add_on_play_message_post_callback(const play_msg_callback_t & callback)
delete_on_play_message_callback(const callback_handle_t & handle)
Signed-off-by: Michael Orlov michael.orlov@apex.ai