-
Notifications
You must be signed in to change notification settings - Fork 240
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Delete obsolete compression_options.cpp from rosbag2_cpp #1078
Delete obsolete compression_options.cpp from rosbag2_cpp #1078
Conversation
compression_options.cpp was supposed to be moved to the `rosbag2_compression` package in #257 but was forgotten to delete from `rosbag2_cpp` package. Signed-off-by: Michael Orlov <michael.orlov@apex.ai>
Gist: https://gist.githubusercontent.com/MichaelOrlov/201735aaef5920823af8bfa03834ca97/raw/68fc92afd56106dda438b8e3ac5b74902892dc5e/ros2.repos |
New warning on Windows build is a known issue and has already been fixed. |
Should this be backported? I just spent a few minutes searching for the compression options header in humble. |
@Mergifyio backport humble |
✅ Backports have been created
|
compression_options.cpp was supposed to be moved to the `rosbag2_compression` package in #257 but was forgotten to delete from `rosbag2_cpp` package. Signed-off-by: Michael Orlov <michael.orlov@apex.ai> Signed-off-by: Michael Orlov <michael.orlov@apex.ai> (cherry picked from commit 50e28cb) Co-authored-by: Michael Orlov <michael.orlov@apex.ai>
Closes #1071
compression_options.cpp
was supposed to be moved to therosbag2_compression
package in #257 but was forgotten to delete fromrosbag2_cpp
package. Deleting it now to avoid confusion.Signed-off-by: Michael Orlov michael.orlov@apex.ai