[Humble] Fix hangout in rosbag2 player and recorder when pressing CTRL+C (backport #1081)
#1085
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![mergify[bot]](https://avatars.githubusercontent.com/in/10562?s=60&v=4){kind=small}
) Disable SIGINT handler in KeyboardHandler instantiated from rosbag2 player and recorder. Since we have already overriding SIGINT on upper python level or inside rclcpp::init() and correctly finishing application with proper calling of all destructors upon receiving SIGINT Signed-off-by: Michael Orlov <michael.orlov@apex.ai> Signed-off-by: Michael Orlov <michael.orlov@apex.ai> (cherry picked from commit f629e45)
mergify
bot
requested review from
MichaelOrlov and
hidmic
and removed request for
a team
MichaelOrlov
changed the title
CTRL+C (backport #1081)CTRL+C (backport #1081)
|
Gist: https://gist.githubusercontent.com/MichaelOrlov/c8b17a2ccf75e73a9fd05f7372ac47e0/raw/0c8513cd6d420b8a9873e915e93861b41cd274c0/ros2.repos
|
|
Failure on Linux and Windows CI jobs are unrelated and present on baseline. |
emersonknapp
approved these changes
Sep 22, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is an automatic backport of pull request #1081 done by Mergify.
Mergify commands and options
More conditions and actions can be found in the documentation.
You can also trigger Mergify actions by commenting on this pull request:
@Mergifyio refreshwill re-evaluate the rules@Mergifyio rebasewill rebase this PR on its base branch@Mergifyio updatewill merge the base branch into this PR@Mergifyio backport <destination>will backport this PR on<destination>branchAdditionally, on Mergify dashboard you can:
Finally, you can contact us on https://mergify.com