Fix hangout in rosbag2 player and recorder when pressing CTRL+C
#1081
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Disable SIGINT handler in KeyboardHandler instantiated from rosbag2 player and recorder. Since we have already overriding SIGINT on upper python level or inside rclcpp::init() and correctly finishing application with proper calling of all destructors upon receiving SIGINT Signed-off-by: Michael Orlov <michael.orlov@apex.ai>
MichaelOrlov
requested review from
emersonknapp and
jhdcs
and removed request for
a team
emersonknapp
approved these changes
Sep 8, 2022
|
Gist: https://gist.githubusercontent.com/MichaelOrlov/8b1f44ec30da7cbf685d25a8290e2459/raw/571667e93bb076cef5922df3e096645f31e6cb84/ros2.repos
|
|
Warning on Windows build is known issue existing on baseline and will be handled in #1084 |
delete-merged-branch
bot
deleted the
morlov/disable_sigint_in_keyboard_handler_from_rosbag2
branch
|
https://github.com/Mergifyio backport humble |
✅ Backports have been created
|
mergify bot
pushed a commit
that referenced
this pull request
Sep 10, 2022
) Disable SIGINT handler in KeyboardHandler instantiated from rosbag2 player and recorder. Since we have already overriding SIGINT on upper python level or inside rclcpp::init() and correctly finishing application with proper calling of all destructors upon receiving SIGINT Signed-off-by: Michael Orlov <michael.orlov@apex.ai> Signed-off-by: Michael Orlov <michael.orlov@apex.ai> (cherry picked from commit f629e45)
|
This pull request has been mentioned on ROS Discourse. There might be relevant details there: https://discourse.ros.org/t/ros-2-tsc-meeting-minutes-2022-9-15/27394/1 |
MichaelOrlov
added a commit
that referenced
this pull request
Sep 23, 2022
) (#1085) Disable SIGINT handler in KeyboardHandler instantiated from rosbag2 player and recorder. Since we have already overriding SIGINT on upper python level or inside rclcpp::init() and correctly finishing application with proper calling of all destructors upon receiving SIGINT Signed-off-by: Michael Orlov <michael.orlov@apex.ai> Signed-off-by: Michael Orlov <michael.orlov@apex.ai> (cherry picked from commit f629e45) Co-authored-by: Michael Orlov <michael.orlov@apex.ai>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We don't need to explicitly handle
SIGINTinKeyboardHandlerinstantiated from rosbag2 executables since we have already overridingSIGINTon upper python level or insiderclcpp::init()and correctly finishing application with proper calling of all destructors upon receivingSIGINTvia checkingrclcpp::ok()method in infinite loop.Please note that it's almost impossible to cover this fix in unit tests since
gtestusing redirection of the standard input to the file andKeyboardHandlerhas detection for this special case and automatically disable keyboard handling from standard input on construction.