Fix for ros2 bag play exit with non-zero code on SIGINT #1126
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MichaelOrlov
force-pushed
the
morlov/fix-for-ros2-bag-play-exitcode-2-on-sigint
branch
from
0f7b6db
to
b1de937
Compare
- Don't allow to propagate KeyboardInterrupt exception on upper level from python wrapper for play verb. - Fixed incorrect errors check in process_execution infrastructure when SIG_INT not processed in child process. Signed-off-by: Michael Orlov <michael.orlov@apex.ai>
MichaelOrlov
force-pushed
the
morlov/fix-for-ros2-bag-play-exitcode-2-on-sigint
branch
from
b1de937
to
476291a
Compare
|
Gist: https://gist.githubusercontent.com/MichaelOrlov/aade93f33f4aaa1e9c01f5c1b03a246d/raw/e8932793f1fbb3eb9403cca35e2faed867f0419b/ros2.repos
|
MichaelOrlov
requested review from
gbiggs,
hidmic,
emersonknapp and
christophebedard
and removed request for
a team
|
@emersonknapp @jhdcs @gbiggs Kindly ping for review |
emersonknapp
approved these changes
Nov 2, 2022
delete-merged-branch
bot
deleted the
morlov/fix-for-ros2-bag-play-exitcode-2-on-sigint
branch
|
https://github.com/Mergifyio backport humble |
✅ Backports have been created
|
mergify bot
pushed a commit
that referenced
this pull request
Nov 2, 2022
- Don't allow to propagate KeyboardInterrupt exception on upper level from python wrapper for play verb. - Fixed incorrect errors check in process_execution infrastructure when SIG_INT not processed in child process. Signed-off-by: Michael Orlov <michael.orlov@apex.ai> Signed-off-by: Michael Orlov <michael.orlov@apex.ai> (cherry picked from commit 30d3889)
MichaelOrlov
added a commit
that referenced
this pull request
Nov 3, 2022
- Don't allow to propagate KeyboardInterrupt exception on upper level from python wrapper for play verb. - Fixed incorrect errors check in process_execution infrastructure when SIG_INT not processed in child process. Signed-off-by: Michael Orlov <michael.orlov@apex.ai> Signed-off-by: Michael Orlov <michael.orlov@apex.ai> (cherry picked from commit 30d3889) Co-authored-by: Michael Orlov <michael.orlov@apex.ai>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix for ros2 bag play exit with non-zero code on SIGINT
ros2 bag playexiting with code 2 by SIGINT or CTRL+C #1123KeyboardInterruptexception on upper level from python wrapper forplayverb.SIGINTnot processed in child process.