ignore cast function type warning #116
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Can't this be done with a more narrow scope? |
|
narrowed done to the specific lines of code. Using the diagnostics pragma to ignore the warnings. |
dirk-thomas
reviewed
May 9, 2019
| @@ -170,6 +173,8 @@ static PyMethodDef rosbag2_transport_methods[] = { | |||
| }, | |||
| {nullptr, nullptr, 0, nullptr} /* sentinel */ | |||
| }; | |||
| # pragma GCC diagnostic pop | |||
| #endif | |||
There was a problem hiding this comment.
The inner block should still be used on non-Windows platforms, no? Currently the ifdef wraps all of it - you probably want to endif after line 160 and ifdef again before line 176.
There was a problem hiding this comment.
absolutely! Corrected in 928a4ee
Signed-off-by: Karsten Knese <karsten@openrobotics.org>
Signed-off-by: Karsten Knese <karsten@openrobotics.org>
Signed-off-by: Karsten Knese <karsten@openrobotics.org>
Karsten1987
force-pushed
the
no_cast_function_type_warning
branch
from
656e128
to
928a4ee
Compare
dirk-thomas
approved these changes
May 9, 2019
cottsay
approved these changes
May 9, 2019
|
Have you tried building this on Linux? It seems it fails in the latest release: http://build.ros2.org/view/Dbin_uB64/job/Dbin_uB64__rosbag2_transport__ubuntu_bionic_amd64__binary/1/ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes the warning shown in CentOS. According to https://docs.python.org/3/c-api/structures.html#c.PyMethodDef this cast is correct and necessary. Thus suppress the warning for this package.
CentOS CI: https://ci.ros2.org/job/ci_linux-centos/7/
Warning is unrelated
Signed-off-by: Karsten Knese karsten@openrobotics.org