-
Notifications
You must be signed in to change notification settings - Fork 245
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ignore cast function type warning #116
Conversation
Can't this be done with a more narrow scope? |
@@ -170,6 +173,8 @@ static PyMethodDef rosbag2_transport_methods[] = { | |||
}, | |||
{nullptr, nullptr, 0, nullptr} /* sentinel */ | |||
}; | |||
# pragma GCC diagnostic pop | |||
#endif |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The inner block should still be used on non-Windows platforms, no? Currently the ifdef
wraps all of it - you probably want to endif
after line 160 and ifdef
again before line 176.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
absolutely! Corrected in 928a4ee
Signed-off-by: Karsten Knese <karsten@openrobotics.org>
Signed-off-by: Karsten Knese <karsten@openrobotics.org>
Signed-off-by: Karsten Knese <karsten@openrobotics.org>
656e128
to
928a4ee
Compare
Have you tried building this on Linux? It seems it fails in the latest release: http://build.ros2.org/view/Dbin_uB64/job/Dbin_uB64__rosbag2_transport__ubuntu_bionic_amd64__binary/1/ |
This fixes the warning shown in CentOS. According to https://docs.python.org/3/c-api/structures.html#c.PyMethodDef this cast is correct and necessary. Thus suppress the warning for this package.
CentOS CI: https://ci.ros2.org/job/ci_linux-centos/7/
Warning is unrelated
Signed-off-by: Karsten Knese karsten@openrobotics.org