Fix for flaky TimeControllerClockTest::unpaused_sleep_returns_true
#1290
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…test Signed-off-by: Michael Orlov <michael.orlov@apex.ai>
MichaelOrlov
requested review from
gbiggs,
emersonknapp,
clalancette and
james-rms
and removed request for
a team
|
Gist: https://gist.githubusercontent.com/MichaelOrlov/2d76c63521ac58a2361a031ebf7203ab/raw/5dde77fb7f573c2611ed329eb1fefd9efe804024/ros2.repos
|
|
@emersonknapp or @clalancette Wouldn't you mind to quickly review and approve this PR - there are literally a couple of lines in test and bringing in one API from inner pimpl time clock class. |
delete-merged-branch
bot
deleted the
morlov/fix_for_flaky_time_controler_clock_test
branch
This was referenced Jun 7, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
rosbag2_cpp/test_time_controller_clockon nightly_win_rep #1282It was a problem in test since we were not able to properly get the same time source for
now()for measuring start point and delay forsleep_until(timepoint)API.ros_to_steady(timepoint)API inTimeControllerClockclass from inner implementation layer to be able to transformTimeControllerClock::now()in to the steady clock domain.