Fix warning from ClassLoader in sequential compression reader and writer #1299
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Fix for warning messages "Warning: class_loader.ClassLoader: SEVERE WARNING!!! Attempting to unload library while objects created by this loader exist in the heap!" Signed-off-by: Michael Orlov <michael.orlov@apex.ai>
MichaelOrlov
requested review from
gbiggs,
jhdcs,
emersonknapp and
james-rms
and removed request for
a team and
gbiggs
james-rms
approved these changes
Apr 19, 2023
|
Gist: https://gist.githubusercontent.com/MichaelOrlov/4c8aa0c122501a4120e6d8a0f53c50a3/raw/df1c6de050bd4e9fd7aa2d567796fc64f3d880b1/ros2.repos
|
|
https://github.com/Mergifyio backport humble |
✅ Backports have been created
|
|
https://github.com/Mergifyio backport iron |
✅ Backports have been created
|
MichaelOrlov
added a commit
that referenced
this pull request
May 4, 2023
…ter (#1299) (#1316) - Fix for warning messages "Warning: class_loader.ClassLoader: SEVERE WARNING!!! Attempting to unload library while objects created by this loader exist in the heap!" Signed-off-by: Michael Orlov <michael.orlov@apex.ai> (cherry picked from commit dded5cf) Co-authored-by: Michael Orlov <michael.orlov@apex.ai>
|
This pull request has been mentioned on ROS Discourse. There might be relevant details there: https://discourse.ros.org/t/ros-2-tsc-meeting-minutes-2023-05-18/31587/1 |
This was referenced May 26, 2023
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
RCA:
It was incorrect order of objects destruction.
First should be destructed child objects produced by
compression_factorysuch ascompressoranddecompressorsince insidecompression_factorydestructor will be called ClassLoader destructor which will generate such warning.