Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add extra checks in execute_and_wait_until_completion(..) #1346

Merged
merged 1 commit into from
May 26, 2023
Merged

Add extra checks in execute_and_wait_until_completion(..) #1346

merged 1 commit into from
May 26, 2023

Conversation

MichaelOrlov
Copy link
Contributor

@MichaelOrlov
Add extra checks in execute_and_wait_until_completion(..)
43e56a0 
- Add check if process was terminated by the signal or really exited

Signed-off-by: Michael Orlov <michael.orlov@apex.ai>
@MichaelOrlov MichaelOrlov marked this pull request as ready for review May 24, 2023 07:47
@MichaelOrlov MichaelOrlov requested a review from a team as a code owner May 24, 2023 07:47
@MichaelOrlov MichaelOrlov requested review from gbiggs, james-rms and emersonknapp and removed request for a team May 24, 2023 07:47
@MichaelOrlov
Copy link
Contributor Author

Gist: https://gist.githubusercontent.com/MichaelOrlov/c17602b994098a21f4dd5d7fa34ef2ab/raw/4a7bffa67fac6e75b126ce9ef4e9d9ab529530ae/ros2.repos
BUILD args: --packages-above-and-dependencies rosbag2_test_common rosbag2_tests
TEST args: --packages-above rosbag2_test_common rosbag2_tests
ROS Distro: rolling
Job: ci_launcher
ci_launcher ran: https://ci.ros2.org/job/ci_launcher/12130

  • Linux Build Status
  • Linux-aarch64 Build Status
  • Windows Build Status

@MichaelOrlov MichaelOrlov merged commit 1215440 into rolling May 26, 2023
13 checks passed
@delete-merged-branch delete-merged-branch bot deleted the morlov/add_extra_checks_in_execute_and_wait branch May 26, 2023 17:38
@MichaelOrlov
Copy link
Contributor Author

https://github.com/Mergifyio backport iron

@mergify
Copy link

mergify bot commented May 26, 2023 •
edited
Loading

backport iron

✅ Backports have been created

mergify bot pushed a commit that referenced this pull request May 26, 2023
@MichaelOrlov @mergify
Add extra checks in execute_and_wait_until_completion(..) (#1346)
da3f160 
- Add check if process was terminated by the signal or really exited

Signed-off-by: Michael Orlov <michael.orlov@apex.ai>
(cherry picked from commit 1215440)
@mergify mergify bot mentioned this pull request May 26, 2023
Merged
@MichaelOrlov
Copy link
Contributor Author

https://github.com/Mergifyio backport humble

@mergify
Copy link

mergify bot commented May 26, 2023 •
edited
Loading

backport humble

✅ Backports have been created

mergify bot pushed a commit that referenced this pull request May 26, 2023
@MichaelOrlov @mergify
Add extra checks in execute_and_wait_until_completion(..) (#1346)
0d32971 
- Add check if process was terminated by the signal or really exited

Signed-off-by: Michael Orlov <michael.orlov@apex.ai>
(cherry picked from commit 1215440)
@mergify mergify bot mentioned this pull request May 26, 2023
Merged
MichaelOrlov added a commit that referenced this pull request May 30, 2023
@mergify @MichaelOrlov
Add extra checks in execute_and_wait_until_completion(..) (#1346) (#1357
bb901c1 
)

- Add check if process was terminated by the signal or really exited

Signed-off-by: Michael Orlov <michael.orlov@apex.ai>
(cherry picked from commit 1215440)

Co-authored-by: Michael Orlov <michael.orlov@apex.ai>
MichaelOrlov added a commit that referenced this pull request May 30, 2023
@mergify @MichaelOrlov
Add extra checks in execute_and_wait_until_completion(..) (#1346) (#1356
4a36e3c 
)

- Add check if process was terminated by the signal or really exited

Signed-off-by: Michael Orlov <michael.orlov@apex.ai>
(cherry picked from commit 1215440)

Co-authored-by: Michael Orlov <michael.orlov@apex.ai>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@emersonknapp emersonknapp emersonknapp approved these changes

@gbiggs gbiggs Awaiting requested review from gbiggs gbiggs is a code owner automatically assigned from ros2/tooling-reviewers

@james-rms james-rms Awaiting requested review from james-rms james-rms is a code owner automatically assigned from ros2/tooling-reviewers

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@MichaelOrlov @emersonknapp