Fix a clang warning about uninitialized variable. #1370
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In the tests for the type description hash, we were forgetting to initialize the endpoint_type, which is necessary when constructing an rclcpp::TopicEndpointInfo object. Just set it to INVALID here, as we don't care whether this is a publisher or subscriber. Signed-off-by: Chris Lalancette <clalancette@gmail.com>
clalancette
requested review from
MichaelOrlov and
james-rms
and removed request for
a team
|
CI:
|
MichaelOrlov
added a commit
that referenced
this pull request
Sep 15, 2023
Signed-off-by: Michael Orlov <michael.orlov@apex.ai>
MichaelOrlov
added a commit
that referenced
this pull request
Sep 15, 2023
…(backport #1440) (#1448) * Fix uninitialized value pointed out by clang static analysis. (#1440) When constructing rclcpp::TopicEndpointInfo from an rcl_topic_endpoint_info_t, one of the fields it uses is the 'qos_profile'. But this particular test was forgetting to initialize that field, leading to access of uninitialized data. Just set it to default here. Signed-off-by: Chris Lalancette <clalancette@gmail.com> (cherry picked from commit 9870868) # Conflicts: # rosbag2_transport/test/rosbag2_transport/test_type_description_hash.cpp * Fix merge conflicts and add backport for the #1370 Signed-off-by: Michael Orlov <michael.orlov@apex.ai> --------- Signed-off-by: Michael Orlov <michael.orlov@apex.ai> Co-authored-by: Chris Lalancette <clalancette@gmail.com> Co-authored-by: Michael Orlov <michael.orlov@apex.ai>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In the tests for the type description hash, we were forgetting to initialize the endpoint_type, which is necessary when constructing an rclcpp::TopicEndpointInfo object. Just set it to INVALID here, as we don't care whether this is a publisher or subscriber.