Update rosbag2_storage_sqlite3 to C++17. #1501
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Chris Lalancette <clalancette@gmail.com>
clalancette
requested review from
MichaelOrlov and
hidmic
and removed request for
a team
|
CI:
|
fujitatomoya
approved these changes
Nov 27, 2023
MichaelOrlov
approved these changes
Nov 27, 2023
MichaelOrlov
pushed a commit
that referenced
this pull request
Feb 2, 2024
Signed-off-by: Chris Lalancette <clalancette@gmail.com> (cherry picked from commit 9855072)
MichaelOrlov
pushed a commit
that referenced
this pull request
Feb 2, 2024
Signed-off-by: Chris Lalancette <clalancette@gmail.com> (cherry picked from commit 9855072)
MichaelOrlov
added a commit
that referenced
this pull request
Feb 3, 2024
…ort #1558) (#1564) * Remove rcpputils::fs dependencies from rosbag2_storages (#1558) * Remove rcpputils::fs dependencies from rosbag2_storages Original author: Kenta Yonekura <yoneken@ieee.org> Signed-off-by: Roman Sokolkov <rsokolkov@gmail.com> * Use path::generic_string() for Windows compatibility Co-authored with Kenta Yonekura <yoneken@ieee.org> Signed-off-by: Roman Sokolkov <rsokolkov@gmail.com> * Fix linter errors in osbag2_storage_sqlite3 Signed-off-by: Roman Sokolkov <rsokolkov@gmail.com> --------- Signed-off-by: Roman Sokolkov <rsokolkov@gmail.com> Co-authored-by: Kenta Yonekura <yoneken@ieee.org> (cherry picked from commit edda376) # Conflicts: # rosbag2_storage_mcap/test/rosbag2_storage_mcap/test_mcap_storage.cpp # rosbag2_storage_sqlite3/src/rosbag2_storage_sqlite3/sqlite_storage.cpp # rosbag2_storage_sqlite3/test/rosbag2_storage_sqlite3/test_sqlite_storage.cpp * Resolve merge conflicts Signed-off-by: Michael Orlov <michael.orlov@apex.ai> * Update rosbag2_storage_sqlite3 to C++17. (#1501) Signed-off-by: Chris Lalancette <clalancette@gmail.com> (cherry picked from commit 9855072) --------- Signed-off-by: Michael Orlov <michael.orlov@apex.ai> Co-authored-by: Roman <rsokolkov@gmail.com> Co-authored-by: Michael Orlov <michael.orlov@apex.ai> Co-authored-by: Chris Lalancette <clalancette@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.