Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

remove unused headers #1544

Merged
merged 1 commit into from Jan 26, 2024
Merged

remove unused headers #1544

merged 1 commit into from Jan 26, 2024

Conversation

uupks
Copy link
Contributor

@uupks uupks commented Jan 19, 2024

remove filesystem header file since it‘s never been used

@uupks
remove unused headers
a5143a3 
remove filesystem header file since it‘s never been used

Signed-off-by: uupks <uupks0325@gmail.com>
@uupks uupks requested a review from a team as a code owner January 19, 2024 06:26
@uupks uupks requested review from gbiggs and jhdcs and removed request for a team January 19, 2024 06:26
MichaelOrlov
MichaelOrlov approved these changes Jan 26, 2024
View reviewed changes
Copy link
Contributor

@MichaelOrlov MichaelOrlov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@clalancette
Copy link
Contributor

CI:

  • Linux Build Status
  • Linux-aarch64 Build Status
  • Windows Build Status

fujitatomoya
fujitatomoya approved these changes Jan 26, 2024
View reviewed changes
Copy link
Contributor

@fujitatomoya fujitatomoya left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm with green CI

@clalancette clalancette merged commit bbbb217 into ros2:rolling Jan 26, 2024
14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MichaelOrlov MichaelOrlov MichaelOrlov approved these changes

@fujitatomoya fujitatomoya fujitatomoya approved these changes

@gbiggs gbiggs Awaiting requested review from gbiggs gbiggs is a code owner automatically assigned from ros2/tooling-reviewers

@jhdcs jhdcs Awaiting requested review from jhdcs jhdcs is a code owner automatically assigned from ros2/tooling-reviewers

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@uupks @clalancette @MichaelOrlov @fujitatomoya