Add error checking on SqliteWrapper deconstructor #169
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Zachary Michaels <zmichaels11@gmail.com>
piraka9011
reviewed
Oct 4, 2019
| if (rc != SQLITE_OK) { | ||
| ROSBAG2_STORAGE_DEFAULT_PLUGINS_LOG_ERROR_STREAM( | ||
| "Could not close open database. Error code: " + std::to_string(rc) + | ||
| " Error message: " + sqlite3_errstr(rc)); |
rosbag2_storage_default_plugins/src/rosbag2_storage_default_plugins/sqlite/sqlite_wrapper.cpp
Outdated
Show resolved
Hide resolved
rosbag2_storage_default_plugins/src/rosbag2_storage_default_plugins/sqlite/sqlite_wrapper.cpp
Outdated
Show resolved
Hide resolved
rosbag2_storage_default_plugins/src/rosbag2_storage_default_plugins/sqlite/sqlite_wrapper.cpp
Show resolved
Hide resolved
Signed-off-by: Zachary Michaels <zmichaels11@gmail.com>
zmichaels11
force-pushed
the
sqlite-storage-check-error-on-close
branch
from
978565e
to
f11e3bb
Compare
Signed-off-by: Zachary Michaels <zmichaels11@gmail.com>
Karsten1987
approved these changes
Oct 7, 2019
Signed-off-by: Zachary Michaels <zmichaels11@gmail.com>
zmichaels11
force-pushed
the
sqlite-storage-check-error-on-close
branch
from
99538db
to
ade278b
Compare
|
Fixed the uncrustify issue on |
|
Karsten1987
reviewed
Oct 7, 2019
...g2_storage_default_plugins/include/rosbag2_storage_default_plugins/sqlite/sqlite_wrapper.hpp
Outdated
Show resolved
Hide resolved
|
Signed-off-by: Zachary Michaels <zmichaels11@gmail.com>
zmichaels11
force-pushed
the
sqlite-storage-check-error-on-close
branch
from
f8c4375
to
fe6ba56
Compare
|
one more round of linux: |
Karsten1987
approved these changes
Oct 8, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Check the return code for sqlite3_close and log to error.
Signed-off-by: Zachary Michaels zmichaels11@gmail.com