-
Notifications
You must be signed in to change notification settings - Fork 242
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add error checking on SqliteWrapper deconstructor #169
Add error checking on SqliteWrapper deconstructor #169
Conversation
Signed-off-by: Zachary Michaels <zmichaels11@gmail.com>
if (rc != SQLITE_OK) { | ||
ROSBAG2_STORAGE_DEFAULT_PLUGINS_LOG_ERROR_STREAM( | ||
"Could not close open database. Error code: " + std::to_string(rc) + | ||
" Error message: " + sqlite3_errstr(rc)); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Newline?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good catch
rosbag2_storage_default_plugins/src/rosbag2_storage_default_plugins/sqlite/sqlite_wrapper.cpp
Outdated
Show resolved
Hide resolved
rosbag2_storage_default_plugins/src/rosbag2_storage_default_plugins/sqlite/sqlite_wrapper.cpp
Outdated
Show resolved
Hide resolved
rosbag2_storage_default_plugins/src/rosbag2_storage_default_plugins/sqlite/sqlite_wrapper.cpp
Show resolved
Hide resolved
Signed-off-by: Zachary Michaels <zmichaels11@gmail.com>
978565e
to
f11e3bb
Compare
Signed-off-by: Zachary Michaels <zmichaels11@gmail.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Signed-off-by: Zachary Michaels <zmichaels11@gmail.com>
99538db
to
ade278b
Compare
Fixed the uncrustify issue on |
...g2_storage_default_plugins/include/rosbag2_storage_default_plugins/sqlite/sqlite_wrapper.hpp
Outdated
Show resolved
Hide resolved
Signed-off-by: Zachary Michaels <zmichaels11@gmail.com>
f8c4375
to
fe6ba56
Compare
Check the return code for sqlite3_close and log to error.
Signed-off-by: Zachary Michaels zmichaels11@gmail.com