-
Notifications
You must be signed in to change notification settings - Fork 245
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Move get_storage_identifier and get_bagfile_size #209
Move get_storage_identifier and get_bagfile_size #209
Conversation
Signed-off-by: Zachary Michaels <zmichaels11@gmail.com>
5c7c723
to
01d1bfb
Compare
This should resolve the failed builds on |
Signed-off-by: Zachary Michaels <zmichaels11@gmail.com>
This PR is ready for review. |
Built |
/** | ||
* Returns the size of the bagfile. | ||
* \returns the size of the bagfile in bytes. | ||
*/ | ||
virtual uint64_t get_bagfile_size() const = 0; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
doesn't #197 state to have bagfile size part of the IO
interface?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think I accidentally re-worded the issue and flipped the function migration.
I'll re-review this work in a few hours
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Update:
The correct wordage should be: "get_bagfile_size
and get_storage_identifier
should be moved to BaseInfoInterface".
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Update:
Corrected wordage in issue
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This LGTM w/ CI.
Let's wait for @Karsten1987 input as this is an architectural change.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks good to me to. Please run CI on it.
@prajakta-gokhale please run CI: |
The MacOS failure seems unrelated to this change, probably related to infrastructure issues. (some MacOS nightlies are also failing like this) |
@prajakta-gokhale Let's retry once? @nuclearsandwich FYI |
Passed on retry! 🎊 |
Resolves Issue: #197
Changes
get_storage_identifier
toBaseInfoInterface
get_bagfile_size
toBaseInfoInterface
Notes
rosbag2_bag_v2
Testing
rosbag2
rosbag2_bag_v2