Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add unit test for SequentialReader when metadata file does not exist #254

Merged
merged 3 commits into from
Jan 17, 2020
Merged

Add unit test for SequentialReader when metadata file does not exist #254

merged 3 commits into from
Jan 17, 2020

Conversation

zmichaels11
Copy link
Contributor

@zmichaels11 zmichaels11 commented Jan 14, 2020 •
edited
Loading

Changes

Issues

Signed-off-by: Zachary Michaels zmichaels11@gmail.com

piraka9011
piraka9011 approved these changes Jan 14, 2020
View reviewed changes
Copy link
Contributor

@piraka9011 piraka9011 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM :shipit:

@zmichaels11 zmichaels11 marked this pull request as ready for review January 14, 2020 23:46
Karsten1987
Karsten1987 approved these changes Jan 15, 2020
View reviewed changes
Copy link
Collaborator

@Karsten1987 Karsten1987 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is great. Thanks for adding this extra test which hopefully should allow us to avoid these kind of bugs more easily in the future.

Please run CI for this together with the rosbag2_bag_v2 repo.

@zmichaels11
Copy link
Contributor Author

@ros2/aws-oncall - please run this CI job
Gist: https://gist.githubusercontent.com/zmichaels11/543a323a0b3788054a44899fc4eecfd5/raw/48a24b6fa82faaca8463a92fbffc594f0bfc7d19/ros2.repos
BUILD args: --packages-up-to rosbag2_cpp
TEST args: --packages-select rosbag2_cpp
Job: ci_launcher

@prajakta-gokhale
Copy link

prajakta-gokhale commented Jan 15, 2020 •
edited
Loading

CI for rosbag2_cpp:

  • Linux Build Status
  • Linux-aarch64 Build Status
  • macOS Build Status
  • Windows Build Status

CI with rosbag2_cpp and rosbag2_bag_v2:

  • Linux Build Status
  • Linux-aarch64 Build Status
  • macOS Build Status
  • Windows Build Status

@zmichaels11
Copy link
Contributor Author

zmichaels11 commented Jan 15, 2020 •
edited
Loading

rosbag2_bag_v2 isn't on the repos file. I'll add it manually

Edit:
Try this ros2.repos:
https://gist.githubusercontent.com/zmichaels11/543a323a0b3788054a44899fc4eecfd5/raw/b983d85e735c80a1cca3ab36e3a3ae2839c07224/ros2.repos

@zmichaels11
Copy link
Contributor Author

I updated the gist (see above) to include the rosbag2_bag_v2 fix
I also cancelled the in-flight tests because macOS was failing due to unused variable. (now removed)

@ros2/aws-oncall - please run this CI job
Gist: https://gist.githubusercontent.com/zmichaels11/543a323a0b3788054a44899fc4eecfd5/raw/b983d85e735c80a1cca3ab36e3a3ae2839c07224/ros2.repos
BUILD args: --packages-up-to rosbag2_cpp rosbag2_bag_v2
TEST args: --packages-select rosbag2_cpp
Job: ci_launcher

@prajakta-gokhale
Copy link

CI again for rosbag2_cpp and rosbag2_bag_v2:

  • Linux Build Status
  • Linux-aarch64 Build Status
  • macOS Build Status
  • Windows Build Status

@zmichaels11
Copy link
Contributor Author

I made a mistake, CI needs to run with packages-up-to rosbag2_bag_v2_plugins

@Karsten1987
Copy link
Collaborator

You'd need to start a packaging job to test the rosbag2_bag_v2_plugin as it requires the ros1_bridge and therefore melodic to be sourced beforehand.

@Karsten1987 Karsten1987 mentioned this pull request Jan 15, 2020
Merged
@zmichaels11 zmichaels11 force-pushed the zmichaels11/fix_reader_storage_options_bug branch from e2dc4bb to 9a84b85 Compare January 15, 2020 17:34
@zmichaels11
Copy link
Contributor Author

@thomas-moulard do we have the ability to do packaging job launches?

@zmichaels11
Copy link
Contributor Author

zmichaels11 commented Jan 15, 2020 •
edited
Loading

Packaging CI:

  • Linux Build Status

Edit: rerun since I configured the CI wrong

@zmichaels11
Fix bug where SequentialReader could not open storage when metadata f…
61a1836 
…ile doesn't exist

Signed-off-by: Zachary Michaels <zmichaels11@gmail.com>
@zmichaels11
Add line break
4eaa784 
Signed-off-by: Zachary Michaels <zmichaels11@gmail.com>
@zmichaels11
Remove unused constant variable
ab11443 
Signed-off-by: Zachary Michaels <zmichaels11@gmail.com>
@zmichaels11 zmichaels11 force-pushed the zmichaels11/fix_reader_storage_options_bug branch from 9a84b85 to ab11443 Compare January 16, 2020 18:20
@zmichaels11 zmichaels11 changed the title Pass storage_id in SequentialReader::open when metadata file doesn't exist. Add unit test for SequentialReader when metadata file does not exist Jan 16, 2020
@zmichaels11
Copy link
Contributor Author

The changes to rosbag2_cpp introduced to this PR were merged in with PR #257.
This PR is now just a new e2e test so I'll run packaging on the issue over in rosbag2_bag_v2.

@ros2/aws-oncall - please run this CI job
Gist: https://gist.githubusercontent.com/zmichaels11/13732b60becb45252e8c8f5796267158/raw/48a24b6fa82faaca8463a92fbffc594f0bfc7d19/ros2.repos
BUILD args: --packages-up-to rosbag2_cpp
TEST args: --packages-select rosbag2_cpp
Job: ci_launcher

@piraka9011
Copy link
Contributor

  • Linux Build Status
  • Linux-aarch64 Build Status
  • macOS Build Status
  • Windows Build Status

@zmichaels11 zmichaels11 merged commit a54dce4 into ros2:master Jan 17, 2020
@zmichaels11 zmichaels11 deleted the zmichaels11/fix_reader_storage_options_bug branch January 17, 2020 18:15
@zmichaels11 zmichaels11 mentioned this pull request Jan 22, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Karsten1987 Karsten1987 Karsten1987 approved these changes

@piraka9011 piraka9011 piraka9011 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@zmichaels11 @prajakta-gokhale @Karsten1987 @piraka9011