-
Notifications
You must be signed in to change notification settings - Fork 245
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add compression factory stubs #311
Conversation
Signed-off-by: Anas Abou Allaban <aabouallaban@pm.me>
rosbag2_compression/include/rosbag2_compression/compression_options.hpp
Outdated
Show resolved
Hide resolved
Signed-off-by: Anas Abou Allaban <aabouallaban@pm.me>
rosbag2_compression/src/rosbag2_compression/compression_factory_impl.hpp
Outdated
Show resolved
Hide resolved
Signed-off-by: Anas Abou Allaban <allabana@amazon.com>
rosbag2_compression/include/rosbag2_compression/compression_factory.hpp
Outdated
Show resolved
Hide resolved
rosbag2_compression/include/rosbag2_compression/compression_factory.hpp
Outdated
Show resolved
Hide resolved
rosbag2_compression/src/rosbag2_compression/compression_factory_impl.hpp
Show resolved
Hide resolved
Signed-off-by: Anas Abou Allaban <allabana@amazon.com>
Signed-off-by: Anas Abou Allaban <aabouallaban@pm.me>
This looks like it introduced a build regression on windows.
|
@piraka9011 please make sure to run CI before merging PRs. |
@piraka9011 If this isn't being fixes before the end of today please revert the PR today to allow nightly jobs in the coming day to pass. |
I assume that an include is missing: https://en.cppreference.com/w/cpp/error/logic_error |
Potential fix: #314 |
Yes that was an error on my part. Jumped the gun on the merge. |
Add the initial stubs of the
compression_factory
used to create de/compressors.Part of #297.
Signed-off-by: Anas Abou Allaban aabouallaban@pm.me