Remove relative paths from includes #405
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jacobperron
reviewed
May 6, 2020
|
Why not put these in |
I think it would create a circular dependency since the involved classes are mocks of objects declared in |
…ncludes are not required Signed-off-by: Zachary Michaels <zmichaels11@gmail.com>
zmichaels11
force-pushed
the
zmichaels11/compression/replace-relative-includes
branch
from
55a351e
to
9cb71c3
Compare
piraka9011
approved these changes
May 7, 2020
Karsten1987
approved these changes
May 7, 2020
jacobperron
approved these changes
May 7, 2020
|
Consider opening a ticket to track the follow-up task of de-duplicating code. |
|
|
CI comes back as expected. Going to merge and cut a new release to unblock the Foxy beta release. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Addsrosbag2_cpp/testpath to includes inrosbag2_compressionto replace relative includes.Duplicate mocks from
rosbag2_cppinrosbag2_compressionso relative includes can be removed.This should resolve this issue: #404
Follow-up work should be done to de-duplicate this code.
Signed-off-by: Zachary Michaels zmichaels11@gmail.com