Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

AMENT_IGNORE rosbag2_py for now #509

Merged
merged 12 commits into from
Aug 15, 2020
Merged

AMENT_IGNORE rosbag2_py for now #509

merged 12 commits into from
Aug 15, 2020

Conversation

mabelzhang
Copy link
Contributor

@mabelzhang mabelzhang commented Aug 14, 2020

Adding AMENT_IGNORE to rosbag2_py, due to Nightly failures on Debug mode in Windows #504 and Linux with Clang #505.
We have a solution for Linux with Clang that passes the compiler but the tests are failing.
Still need to look into Windows.

We opted to add AMENT_IGNORE instead of reverting #308 because given that there were a large number of lines added in that PR, we thought this would make it easier to review the patch, which we will make to fix the errors.

CI is green, with Clang and build type Debug, running on meta package rosbag2

  • Linux Build Status

(Ignore all the commits from my old fork. Will clean up the commit comments in the squashed commit when merging.)

@clalancette
Copy link
Contributor

The PR job is failing because you'll also need to remove this from the rosbag2 exec_depend:

<exec_depend>rosbag2_py</exec_depend>

Signed-off-by: Mabel Zhang <mabel@openrobotics.org>
@clalancette
Copy link
Contributor

The PR job is still failing. Is that expected?

Relatedly, it looks like pybind11_vendor needs to be released into rolling. I'll suggest that we do that before removing the AMENT_IGNORE here.

@mabelzhang
Copy link
Contributor Author

Are you referring to the Rpr__rosbag2__ubuntu_focal_amd64? That seems to normally fail. Some of the recently merged PRs pass everything except for that one.

@mabelzhang
Copy link
Contributor Author

Looks just yellow. I think it's because some of the end to end tests are flaky.

@clalancette
Copy link
Contributor

Are you referring to the Rpr__rosbag2__ubuntu_focal_amd64? That seems to normally fail. Some of the recently merged PRs pass everything except for that one.

Yeah, looking at an earlier PR job, it looks like there were 4 failures, while this one has 8. But still, I don't see how this particular PR would cause that, so I'm still going to approve. @emersonknapp Do you have anything to add here? Otherwise we'll go ahead and merge.

@mabelzhang mabelzhang merged commit d14df31 into master Aug 15, 2020
@mabelzhang mabelzhang deleted the ignore_rosbag2_py branch August 15, 2020 00:12
emersonknapp pushed a commit that referenced this pull request Feb 2, 2021
* AMENT_IGNORE rosbag2_py

Signed-off-by: Mabel Zhang <mabel@openrobotics.org>

* remove rosbag2_py from meta package

Signed-off-by: Mabel Zhang <mabel@openrobotics.org>
agutenkunst pushed a commit to agutenkunst/rosbag2 that referenced this pull request Feb 5, 2021
* AMENT_IGNORE rosbag2_py

Signed-off-by: Mabel Zhang <mabel@openrobotics.org>

* remove rosbag2_py from meta package

Signed-off-by: Mabel Zhang <mabel@openrobotics.org>
agutenkunst pushed a commit to agutenkunst/rosbag2 that referenced this pull request Feb 5, 2021
* AMENT_IGNORE rosbag2_py

Signed-off-by: Mabel Zhang <mabel@openrobotics.org>

* remove rosbag2_py from meta package

Signed-off-by: Mabel Zhang <mabel@openrobotics.org>
Signed-off-by: Alexander Gutenkunst <alex.gutenkunst+github.com>
emersonknapp pushed a commit that referenced this pull request Feb 17, 2021
* AMENT_IGNORE rosbag2_py

Signed-off-by: Mabel Zhang <mabel@openrobotics.org>

* remove rosbag2_py from meta package

Signed-off-by: Mabel Zhang <mabel@openrobotics.org>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants