-
Notifications
You must be signed in to change notification settings - Fork 240
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix rosbag2_py bug when using libc++ #529
Conversation
Signed-off-by: Mabel Zhang <mabel@openrobotics.org>
Signed-off-by: Mabel Zhang <mabel@openrobotics.org>
Signed-off-by: Mabel Zhang <mabel@openrobotics.org>
Signed-off-by: Mabel Zhang <mabel@openrobotics.org>
…mpts Signed-off-by: Mabel Zhang <mabel@openrobotics.org>
Signed-off-by: Mabel Zhang <mabel@openrobotics.org>
Signed-off-by: Mabel Zhang <mabel@openrobotics.org>
Signed-off-by: Ivan Santiago Paunovic <ivanpauno@ekumenlabs.com>
Signed-off-by: Ivan Santiago Paunovic <ivanpauno@ekumenlabs.com>
Signed-off-by: Ivan Santiago Paunovic <ivanpauno@ekumenlabs.com>
Signed-off-by: Ivan Santiago Paunovic <ivanpauno@ekumenlabs.com>
0c0a9a1
to
e1b814e
Compare
Signed-off-by: Ivan Santiago Paunovic <ivanpauno@ekumenlabs.com>
readded |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for taking over this issue! I don't think I would have gotten this far. rtti
is beyond me.
I think Windows CI has to pass too before we remove AMENT_IGNORE
(I think that's what you meant too)?
Signed-off-by: Ivan Santiago Paunovic <ivanpauno@ekumenlabs.com>
Signed-off-by: Ivan Santiago Paunovic <ivanpauno@ekumenlabs.com>
6c1e230
to
0c76b14
Compare
Force pushed to please the DCO checker. |
I just realized the CI above wasn't in debug mode. The problem was exposed only in debug mode. Can we rerun in debug mode? These are the parameters https://ci.ros2.org/view/nightly/job/nightly_linux_clang_libcxx/513/ |
It shouldn't make a difference, but trying again in debug mode too: This job is testing directly #531, which is this + fixes on Windows (this PR still has the |
Merging this one, if there's any further comment I can address them in #531. |
@ivanpauno I think this PR may have introduced the warnings in #537. Would you be able to check that and address them if that turns out to be the case? |
Yeah, this seems to be the root cause.
Yes, thanks for bringing this up. |
Signed-off-by: Mabel Zhang <mabel@openrobotics.org> Signed-off-by: Ivan Santiago Paunovic <ivanpauno@ekumenlabs.com> Co-authored-by: Mabel Zhang <mabel@openrobotics.org>
Signed-off-by: Mabel Zhang <mabel@openrobotics.org> Signed-off-by: Ivan Santiago Paunovic <ivanpauno@ekumenlabs.com> Co-authored-by: Mabel Zhang <mabel@openrobotics.org>
This fixes a weird rtti bug in rosbag2_py tests when using.
I will re-add an
AMENT_IGNORE
file before merging, as #504 also needs a fix.Fix #505.