Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

correct master build #552

Merged
merged 1 commit into from Oct 28, 2020
Merged

correct master build #552

merged 1 commit into from Oct 28, 2020

Conversation

Karsten1987
Copy link
Collaborator

something went wrong while rebasing #493
This should help the master build.

@Karsten1987
correct master build
573b5ad 
Signed-off-by: Karsten Knese <Karsten1987@users.noreply.github.com>
@Karsten1987 Karsten1987 requested a review from a team as a code owner October 28, 2020 17:26
@Karsten1987 Karsten1987 requested review from thomas-moulard and emersonknapp and removed request for a team October 28, 2020 17:26
@Karsten1987
Copy link
Collaborator Author

  • Linux Build Status
  • Linux-aarch64 Build Status
  • macOS Build Status
  • Windows Build Status

clalancette
clalancette approved these changes Oct 28, 2020
View reviewed changes
Copy link
Contributor

@clalancette clalancette left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good with green CI.

@Karsten1987 Karsten1987 merged commit 67d193e into master Oct 28, 2020
@delete-merged-branch delete-merged-branch bot deleted the fix_master_build branch October 28, 2020 19:22
emersonknapp pushed a commit that referenced this pull request Feb 2, 2021
@Karsten1987
correct master build (#552)
53a8622 
Signed-off-by: Karsten Knese <Karsten1987@users.noreply.github.com>
emersonknapp pushed a commit that referenced this pull request Feb 17, 2021
@Karsten1987
correct master build (#552)
e22be96 
Signed-off-by: Karsten Knese <Karsten1987@users.noreply.github.com>
skudryas pushed a commit to skudryas/rosbag2 that referenced this pull request Mar 12, 2021
@Karsten1987
correct master build (ros2#552)
5a0db65 
Signed-off-by: Karsten Knese <Karsten1987@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@clalancette clalancette clalancette approved these changes

@thomas-moulard thomas-moulard Awaiting requested review from thomas-moulard

@emersonknapp emersonknapp Awaiting requested review from emersonknapp

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@Karsten1987 @clalancette