Deduplicate SequentialCompressionReader business logic, add fallback to find bagfiles in incorrectly-written metadata #612
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
emersonknapp
requested review from
thomas-moulard and
jikawa-az
and removed request for
a team
…to find bagfiles in incorrectly-written metadata Signed-off-by: Emerson Knapp <eknapp@amazon.com>
emersonknapp
force-pushed
the
emersonknapp/compression-reader-relative-path-fallback
branch
from
fbe3585
to
a68a5a2
Compare
emersonknapp
requested review from
Karsten1987,
zmichaels11 and
piraka9011
and removed request for
thomas-moulard
…open, so as not to affect all the existing rosbag2_cpp tests Signed-off-by: Emerson Knapp <eknapp@amazon.com>
emersonknapp
force-pushed
the
emersonknapp/compression-reader-relative-path-fallback
branch
from
a68a5a2
to
f38f491
Compare
zmichaels11
reviewed
Jan 24, 2021
rosbag2_compression/src/rosbag2_compression/sequential_compression_reader.cpp
Outdated
Show resolved
Hide resolved
rosbag2_compression/src/rosbag2_compression/sequential_compression_reader.cpp
Outdated
Show resolved
Hide resolved
rosbag2_compression/include/rosbag2_compression/sequential_compression_reader.hpp
Outdated
Show resolved
Hide resolved
zmichaels11
reviewed
Jan 25, 2021
rosbag2_compression/include/rosbag2_compression/sequential_compression_reader.hpp
Outdated
Show resolved
Hide resolved
Signed-off-by: Emerson Knapp <eknapp@amazon.com>
emersonknapp
force-pushed
the
emersonknapp/compression-reader-relative-path-fallback
branch
from
56a86e9
to
06142a7
Compare
zmichaels11
approved these changes
Jan 25, 2021
rosbag2_compression/test/rosbag2_compression/test_sequential_compression_reader.cpp
Outdated
Show resolved
Hide resolved
emersonknapp
changed the title
Signed-off-by: Emerson Knapp <eknapp@amazon.com>
|
Gist: https://gist.githubusercontent.com/emersonknapp/480e43e106e4757f36754ecab42a4237/raw/86acb05e94b0c1026e7ea09f43dfd6ce12fa56c0/ros2.repos
|
emersonknapp
added a commit
that referenced
this pull request
Jan 27, 2021
…to find bagfiles in incorrectly-written metadata (#612) * Deduplicate sequentialcompressionreader business logic, add fallback to find bagfiles in incorrectly-written metadata Signed-off-by: Emerson Knapp <eknapp@amazon.com>
emersonknapp
added a commit
that referenced
this pull request
Feb 2, 2021
…to find bagfiles in incorrectly-written metadata (#612) * Deduplicate sequentialcompressionreader business logic, add fallback to find bagfiles in incorrectly-written metadata Signed-off-by: Emerson Knapp <eknapp@amazon.com>
emersonknapp
deleted the
emersonknapp/compression-reader-relative-path-fallback
branch
emersonknapp
added a commit
that referenced
this pull request
Feb 17, 2021
…to find bagfiles in incorrectly-written metadata (#612) * Deduplicate sequentialcompressionreader business logic, add fallback to find bagfiles in incorrectly-written metadata Signed-off-by: Emerson Knapp <eknapp@amazon.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of #557
This PR allows rosbag2 to correctly read the incorrect V4 metadata files being currently written by compressed bags. It removes most of the business logic from the SequentialCompressionReader in preparation for removing the class entirely.