Use unordered map instead of map #65
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Karsten1987
force-pushed
the
feature/use_unordered_map
branch
from
2844fa2
to
86043b7
Compare
sriramster
pushed a commit
to sriramster/rosbag2
that referenced
this pull request
Feb 28, 2019
* ros2GH-23 Get all topics from node and sanitize * ros2GH-23 Move methods to node for better interface * ros2GH-23 Use rmw_serialized_message_t consistently * ros2GH-23 Improve santization of topics * ros2GH-65 Introduce and use better logging macros * ros2GH-23 Use publisher to serialized message directly * ros2GH-23 Improve readability of sanitizing topics and types * ros2GH-23 Allow to write all available topics * ros2GH-23 Add test for record all * ros2GH-23 Cleanup: add missing const ref to record interface * Cleanup for doxygen * Improve topic sanitization - correctly expand topic names using rcl - do not check type correctness (supposed to be done internally) * Pass topic_name by reference
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Replaces the usage of
std::mapwithstd::unordered_mapwhere possible.This pr is based on #57.
Only the last commit is actually part of this pr.