-
Notifications
You must be signed in to change notification settings - Fork 237
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add rosbag2_interfaces package with playback service definitions #728
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'd vote to rename the project to rosbag2_srvs
.
I don't mind too much about the actual services, but some of them can be replaced by std_srvs
.
it's all good. you can go ahead and merge as is. I just wanted to bring it up. |
I'm just presenting where my thinking came from - I don't have strong opinions here, I am definitely open to making changes if there are good counterpoints. For the package naming - I was thinking that potentially |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I agree with your reasoning here. Thanks for the explanations.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks good
Signed-off-by: Emerson Knapp <eknapp@amazon.com>
Signed-off-by: Emerson Knapp <eknapp@amazon.com>
7e9ce9b
to
3fc07ba
Compare
Gist: https://gist.githubusercontent.com/emersonknapp/20e6f6611bb120321b7294df2f6974bb/raw/9560335eef310dd4ebe284927edc903bb23f43a2/ros2.repos |
These .srv definitions will be used to control playback on the Player. Recording controls not yet defined, so none added.
Part of #696
Design at https://github.com/ros2/rosbag2/blob/master/docs/design/rosbag2_playback_time.md