-
Notifications
You must be signed in to change notification settings - Fork 242
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Readers detect storage plugin automatically #972
Comments
I think the idea to automatically load the plugin based on the input file is a good one. Another way to determine the right plugin to load would be to look at the beginning of the input file, looking for particular markers. This seems more reliable than the extension name, and is similar to how |
Agreed - though I think it doesn't hurt to use extension as a hint. Could also do a "try all storage plugins" loop and see if one is successful at opening |
As the number of storage options grows and/or the number of users of alternate storage options grows, this becomes very valuable. This would be a worthwhile enhancement |
Added requirements checklist for this ticket at the bottom of the original description. I think this should address all cases. If those points are completed, it opens up the non-directory ("bare") bag functionality in a way that users have been asking for basically forever. @MichaelOrlov as current maintainer, let me know if you have any input on that design choice |
@emersonknapp Thanks for pinging me in this issue. May be need to add consideration how to handle cases when:
|
I am removing the "Writer" portion of this issue, so that it is more self-contained. |
Description
When using the
ros2 bag
CLI for info, playback, and recording it would be nice to detect the storage plugin based on the file extension.For example if I record an MCAP file using the mcap storage plugin I record to .mcap files. When I want to go and play those files, I'd like to use
Rather than having to specify the plugin manually via:
Similarly, f I specify I want to record to
.mcap
files, the storage plugin should be detected and used for recording.If there are multiple plugins installed which could support the extension that should error and require the user to manually specify the name of their desired storage plugin via the command line flag.
Requirements
Definition: "bare bag" is a standalone file, rather than a directory containing a
metadata.yaml
file and one or more storage files.burst
/convert
/info
/play
/reindex
)The text was updated successfully, but these errors were encountered: