Reader CLI argument consistency pass (coherently enables bare-file) #1073
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Emerson Knapp <emerson.b.knapp@gmail.com>
emersonknapp
requested review from
gbiggs and
jhdcs
and removed request for
a team
emersonknapp
changed the title
|
The code changes look good, though test 3 appears to be failing (it can't find the metadata file, if I'm reading it correctly). Do you think this error is unrelated to your changes? Is it another flaky test? |
|
Need to just roll this into #1072 for end to end to work properly |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Depends on #1072
Part of #972
For all
ros2 bagverbs that create a reader, factor out common options into a single place for consistency. This helps consistently expose the bare file workflow enabled in #1072