Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use thread pool to run benchmark publishers in rosbag2_performance_benchmarking #1250

Merged
merged 11 commits into from Feb 28, 2023
Merged

Use thread pool to run benchmark publishers in rosbag2_performance_benchmarking #1250

merged 11 commits into from Feb 28, 2023

Commits on Feb 27, 2023

  1. Add thread pool for benchmark_publishers execution 

    Signed-off-by: Carlos San Vicente <carlos.sanvicente@apex.ai>
    @carlossvg
    carlossvg committed Feb 27, 2023
    Configuration menu
    Copy the full SHA
    193a52d View commit details
    Browse the repository at this point in the history

  2. Default the number of threads to the number of publishers 

    Signed-off-by: Carlos San Vicente <carlos.sanvicente@apex.ai>
    @carlossvg
    carlossvg committed Feb 27, 2023
    Configuration menu
    Copy the full SHA
    ee025fb View commit details
    Browse the repository at this point in the history

  3. Skip ament_package() call when not building rosbag2_performance_bench… 

    …marking (ros2#1242)

Signed-off-by: Shane Loretz <sloretz@google.com>
Signed-off-by: Carlos San Vicente <carlos.sanvicente@apex.ai>
    @sloretz @carlossvg
    sloretz authored and carlossvg committed Feb 27, 2023
    Configuration menu
    Copy the full SHA
    fa37aca View commit details
    Browse the repository at this point in the history

  4. Update rosbag2_performance/rosbag2_performance_benchmarking/include/r… 

    …osbag2_performance_benchmarking/config_utils.hpp

Co-authored-by: Michael Orlov <morlovmr@gmail.com>
Signed-off-by: Carlos San Vicente <carlos.sanvicente@apex.ai>
    @carlossvg @MichaelOrlov
    carlossvg and MichaelOrlov committed Feb 27, 2023
    Configuration menu
    Copy the full SHA
    0a8813f View commit details
    Browse the repository at this point in the history

  5. Update rosbag2_performance/rosbag2_performance_benchmarking/include/r… 

    …osbag2_performance_benchmarking/thread_pool.hpp

Co-authored-by: Michael Orlov <morlovmr@gmail.com>
Signed-off-by: Carlos San Vicente <carlos.sanvicente@apex.ai>
    @carlossvg @MichaelOrlov
    carlossvg and MichaelOrlov committed Feb 27, 2023
    Configuration menu
    Copy the full SHA
    8619e72 View commit details
    Browse the repository at this point in the history

  6. Update rosbag2_performance/rosbag2_performance_benchmarking/src/bench… 

    …mark_publishers.cpp

Co-authored-by: Michael Orlov <morlovmr@gmail.com>
Signed-off-by: Carlos San Vicente <carlos.sanvicente@apex.ai>
    @carlossvg @MichaelOrlov
    carlossvg and MichaelOrlov committed Feb 27, 2023
    Configuration menu
    Copy the full SHA
    7bb379f View commit details
    Browse the repository at this point in the history

  7. Update rosbag2_performance/rosbag2_performance_benchmarking/include/r… 

    …osbag2_performance_benchmarking/thread_pool.hpp

Co-authored-by: Michael Orlov <morlovmr@gmail.com>
Signed-off-by: Carlos San Vicente <carlos.sanvicente@apex.ai>
    @carlossvg @MichaelOrlov
    carlossvg and MichaelOrlov committed Feb 27, 2023
    Configuration menu
    Copy the full SHA
    6fa2b29 View commit details
    Browse the repository at this point in the history

  8. Update rosbag2_performance/rosbag2_performance_benchmarking/include/r… 

    …osbag2_performance_benchmarking/thread_pool.hpp

Co-authored-by: Michael Orlov <morlovmr@gmail.com>
Signed-off-by: Carlos San Vicente <carlos.sanvicente@apex.ai>
    @carlossvg @MichaelOrlov
    carlossvg and MichaelOrlov committed Feb 27, 2023
    Configuration menu
    Copy the full SHA
    1a9fbfa View commit details
    Browse the repository at this point in the history

  9. Address reviewer comments 

    Signed-off-by: Carlos San Vicente <carlos.sanvicente@apex.ai>
    @carlossvg
    carlossvg committed Feb 27, 2023
    Configuration menu
    Copy the full SHA
    c1e6989 View commit details
    Browse the repository at this point in the history

  10. Address reviewer comments 

    Signed-off-by: Carlos San Vicente <carlos.sanvicente@apex.ai>
    @carlossvg
    carlossvg committed Feb 27, 2023
    Configuration menu
    Copy the full SHA
    1d6ace5 View commit details
    Browse the repository at this point in the history

  11. Address reviewer comments 

    Signed-off-by: Carlos San Vicente <carlos.sanvicente@apex.ai>
    @carlossvg
    carlossvg committed Feb 27, 2023
    Configuration menu
    Copy the full SHA
    66a4ef3 View commit details
    Browse the repository at this point in the history