Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use enum values for offered_qos_profiles in code and string names in serialized metadata #1476

Merged
merged 51 commits into from
Nov 10, 2023
Merged

Use enum values for offered_qos_profiles in code and string names in serialized metadata #1476

merged 51 commits into from
Nov 10, 2023

Commits on Nov 6, 2023

  1. Make C++ QoS YAML (de)serialization compliant with QoS override file … 

    …schema

Signed-off-by: Patrick Roncagliolo <ronca.pat@gmail.com>
Signed-off-by: roncapat <ronca.pat@gmail.com>
    @roncapat
    roncapat committed Nov 6, 2023
    Configuration menu
    Copy the full SHA
    f34e165 View commit details
    Browse the repository at this point in the history

  2. UGLY DRAFT - handle different versions of TopicMetadata 

    Signed-off-by: Patrick Roncagliolo <ronca.pat@gmail.com>
    @roncapat
    roncapat committed Nov 6, 2023
    Configuration menu
    Copy the full SHA
    30832e8 View commit details
    Browse the repository at this point in the history

  3. Handle unknown cases 

    Signed-off-by: Patrick Roncagliolo <ronca.pat@gmail.com>
    @roncapat
    roncapat committed Nov 6, 2023
    Configuration menu
    Copy the full SHA
    8d704fe View commit details
    Browse the repository at this point in the history

  4. Uncrustify 

    Signed-off-by: Patrick Roncagliolo <ronca.pat@gmail.com>
    @roncapat
    roncapat committed Nov 6, 2023
    Configuration menu
    Copy the full SHA
    d0434e3 View commit details
    Browse the repository at this point in the history

  5. Fix test 

    Signed-off-by: Patrick Roncagliolo <ronca.pat@gmail.com>
    @roncapat
    roncapat committed Nov 6, 2023
    Configuration menu
    Copy the full SHA
    545ec1c View commit details
    Browse the repository at this point in the history

  6. Refactor to avoid templates 

    Signed-off-by: Patrick Roncagliolo <ronca.pat@gmail.com>
    @roncapat
    roncapat committed Nov 6, 2023
    Configuration menu
    Copy the full SHA
    ec87bcd View commit details
    Browse the repository at this point in the history

  7. Reduce diff 

    Signed-off-by: Patrick Roncagliolo <ronca.pat@gmail.com>
    @roncapat
    roncapat committed Nov 6, 2023
    Configuration menu
    Copy the full SHA
    4208cd3 View commit details
    Browse the repository at this point in the history

  8. Fix for rosbag2_py 

    Signed-off-by: Patrick Roncagliolo <ronca.pat@gmail.com>
    @roncapat
    roncapat committed Nov 6, 2023
    Configuration menu
    Copy the full SHA
    31d98a9 View commit details
    Browse the repository at this point in the history

  9. Fix missing include (cpplint) 

    Signed-off-by: Patrick Roncagliolo <ronca.pat@gmail.com>
    @roncapat
    roncapat committed Nov 6, 2023
    Configuration menu
    Copy the full SHA
    a6fb35c View commit details
    Browse the repository at this point in the history

  10. WIP: decode everything 

    QoS parsing moved
MCAP code already drafted

Signed-off-by: Patrick Roncagliolo <ronca.pat@gmail.com>
    @roncapat
    roncapat committed Nov 6, 2023
    Configuration menu
    Copy the full SHA
    17281e3 View commit details
    Browse the repository at this point in the history

  11. WIP: decode everything 

    Fix MCAP test compilation

Signed-off-by: Patrick Roncagliolo <ronca.pat@gmail.com>
    @roncapat
    roncapat committed Nov 6, 2023
    Configuration menu
    Copy the full SHA
    823dfba View commit details
    Browse the repository at this point in the history

  12. WIP: decode everything 

    Sqlite3 code
Everything builds up to rosbag2_transport (excluded)

Signed-off-by: Patrick Roncagliolo <ronca.pat@gmail.com>
    @roncapat
    roncapat committed Nov 6, 2023
    Configuration menu
    Copy the full SHA
    afeee44 View commit details
    Browse the repository at this point in the history

  13. WIP: decode everything 

    rosbag2_transport partial rework

Signed-off-by: Patrick Roncagliolo <ronca.pat@gmail.com>
    @roncapat
    roncapat committed Nov 6, 2023
    Configuration menu
    Copy the full SHA
    0b7fc66 View commit details
    Browse the repository at this point in the history

  14. WIP: decode everything 

    rosbag2_transport compiles

Signed-off-by: Patrick Roncagliolo <ronca.pat@gmail.com>
    @roncapat
    roncapat committed Nov 6, 2023
    Configuration menu
    Copy the full SHA
    e4164d6 View commit details
    Browse the repository at this point in the history

  15. WIP: decode everything 

    everything compiles

Signed-off-by: roncapat <ronca.pat@gmail.com>
    @roncapat
    roncapat committed Nov 6, 2023
    Configuration menu
    Copy the full SHA
    b3c1040 View commit details
    Browse the repository at this point in the history

  16. Uncrustify (warning: still draft code) 

    Signed-off-by: roncapat <ronca.pat@gmail.com>
    @roncapat
    roncapat committed Nov 6, 2023
    Configuration menu
    Copy the full SHA
    9a9f9a2 View commit details
    Browse the repository at this point in the history

  17. Uncrustify 

    Signed-off-by: roncapat <ronca.pat@gmail.com>
    @roncapat
    roncapat committed Nov 6, 2023
    Configuration menu
    Copy the full SHA
    57cc668 View commit details
    Browse the repository at this point in the history

  18. Try to export dependency 

    Signed-off-by: roncapat <ronca.pat@gmail.com>
    @roncapat
    roncapat committed Nov 6, 2023
    Configuration menu
    Copy the full SHA
    827df9d View commit details
    Browse the repository at this point in the history

  19. Cpplint 

    Signed-off-by: roncapat <ronca.pat@gmail.com>
    @roncapat
    roncapat committed Nov 6, 2023
    Configuration menu
    Copy the full SHA
    e0483dc View commit details
    Browse the repository at this point in the history

  20. Fix encode bug 

    Signed-off-by: roncapat <ronca.pat@gmail.com>
    @roncapat
    roncapat committed Nov 6, 2023
    Configuration menu
    Copy the full SHA
    1359a47 View commit details
    Browse the repository at this point in the history

  21. Fix transform bug 

    Signed-off-by: roncapat <ronca.pat@gmail.com>
    @roncapat
    roncapat committed Nov 6, 2023
    Configuration menu
    Copy the full SHA
    acf1fc2 View commit details
    Browse the repository at this point in the history

  22. Try to fix runtime error with py constructor 

    Signed-off-by: roncapat <ronca.pat@gmail.com>
    @roncapat
    roncapat committed Nov 6, 2023
    Configuration menu
    Copy the full SHA
    95521bb View commit details
    Browse the repository at this point in the history

  23. Fix "test_record" 

    Signed-off-by: Patrick Roncagliolo <ronca.pat@gmail.com>
    @roncapat
    roncapat committed Nov 6, 2023
    Configuration menu
    Copy the full SHA
    5083ebb View commit details
    Browse the repository at this point in the history

  24. Various fixes 

    Signed-off-by: Patrick Roncagliolo <ronca.pat@gmail.com>
    @roncapat
    roncapat committed Nov 6, 2023
    Configuration menu
    Copy the full SHA
    f20226b View commit details
    Browse the repository at this point in the history

  25. Various fixes 

    Signed-off-by: Patrick Roncagliolo <ronca.pat@gmail.com>
    @roncapat
    roncapat committed Nov 6, 2023
    Configuration menu
    Copy the full SHA
    b080d4f View commit details
    Browse the repository at this point in the history

  26. Various fixes 

    Signed-off-by: Patrick Roncagliolo <ronca.pat@gmail.com>
    @roncapat
    roncapat committed Nov 6, 2023
    Configuration menu
    Copy the full SHA
    00520e8 View commit details
    Browse the repository at this point in the history

  27. Various fixes 

    Signed-off-by: Patrick Roncagliolo <ronca.pat@gmail.com>
    @roncapat
    roncapat committed Nov 6, 2023
    Configuration menu
    Copy the full SHA
    e22afad View commit details
    Browse the repository at this point in the history

  28. Format 

    Signed-off-by: Patrick Roncagliolo <ronca.pat@gmail.com>
    @roncapat
    roncapat committed Nov 6, 2023
    Configuration menu
    Copy the full SHA
    fbd5846 View commit details
    Browse the repository at this point in the history

  29. Format 

    Signed-off-by: Patrick Roncagliolo <ronca.pat@gmail.com>
    @roncapat
    roncapat committed Nov 6, 2023
    Configuration menu
    Copy the full SHA
    a7a7356 View commit details
    Browse the repository at this point in the history

  30. Tentative fixes 

    Signed-off-by: Patrick Roncagliolo <ronca.pat@gmail.com>
    @roncapat
    roncapat committed Nov 6, 2023
    Configuration menu
    Copy the full SHA
    258fb56 View commit details
    Browse the repository at this point in the history

  31. Fixes 

    Signed-off-by: Patrick Roncagliolo <ronca.pat@gmail.com>
    @roncapat
    roncapat committed Nov 6, 2023
    Configuration menu
    Copy the full SHA
    3c24d68 View commit details
    Browse the repository at this point in the history

  32. MCAP Fixes 

    Signed-off-by: Patrick Roncagliolo <ronca.pat@gmail.com>
    @roncapat
    roncapat committed Nov 6, 2023
    Configuration menu
    Copy the full SHA
    e1dda74 View commit details
    Browse the repository at this point in the history

  33. History QOS Fixes 

    Signed-off-by: Patrick Roncagliolo <ronca.pat@gmail.com>
    @roncapat
    roncapat committed Nov 6, 2023
    Configuration menu
    Copy the full SHA
    189e25b View commit details
    Browse the repository at this point in the history

  34. uncrust 

    Signed-off-by: Patrick Roncagliolo <ronca.pat@gmail.com>
    @roncapat
    roncapat committed Nov 6, 2023
    Configuration menu
    Copy the full SHA
    526f28e View commit details
    Browse the repository at this point in the history

  35. Remove VScode files 

    Signed-off-by: Patrick Roncagliolo <ronca.pat@gmail.com>
    @roncapat
    roncapat committed Nov 6, 2023
    Configuration menu
    Copy the full SHA
    ded8bf3 View commit details
    Browse the repository at this point in the history

  36. PR Diff analysis & reduction 

    Signed-off-by: Patrick Roncagliolo <ronca.pat@gmail.com>
    @roncapat
    roncapat committed Nov 6, 2023
    Configuration menu
    Copy the full SHA
    7f9885e View commit details
    Browse the repository at this point in the history

  37. Refactor conversion snippets 

    Signed-off-by: Patrick Roncagliolo <ronca.pat@gmail.com>
    @roncapat
    roncapat committed Nov 6, 2023
    Configuration menu
    Copy the full SHA
    7b970a3 View commit details
    Browse the repository at this point in the history

  38. Uncrustify 

    Signed-off-by: Patrick Roncagliolo <ronca.pat@gmail.com>
    @roncapat
    roncapat committed Nov 6, 2023
    Configuration menu
    Copy the full SHA
    fe67da8 View commit details
    Browse the repository at this point in the history

  39. Address some comments 

    Signed-off-by: Patrick Roncagliolo <ronca.pat@gmail.com>
    @roncapat
    roncapat committed Nov 6, 2023
    Configuration menu
    Copy the full SHA
    6cd68a2 View commit details
    Browse the repository at this point in the history

  40. Address some comments 

    Signed-off-by: Patrick Roncagliolo <ronca.pat@gmail.com>
    @roncapat
    roncapat committed Nov 6, 2023
    Configuration menu
    Copy the full SHA
    d8243dd View commit details
    Browse the repository at this point in the history

  41. Address some comments 

    Signed-off-by: Patrick Roncagliolo <ronca.pat@gmail.com>
    @roncapat
    roncapat committed Nov 6, 2023
    Configuration menu
    Copy the full SHA
    a3ffbc4 View commit details
    Browse the repository at this point in the history

  42. More fixes 

    Signed-off-by: Patrick Roncagliolo <ronca.pat@gmail.com>
    @roncapat
    roncapat committed Nov 6, 2023
    Configuration menu
    Copy the full SHA
    01f25dd View commit details
    Browse the repository at this point in the history

  43. Fixes for failing tests in the test_qos.cpp 

    - Add Metadata version for encode methods to be able to encode
rclcpp::qos to the old format with enum numbers
- Fix downcast issue in the rclcpp::qos to Rosbag2QoS converter
functions

Signed-off-by: Michael Orlov <michael.orlov@apex.ai>
    @MichaelOrlov @roncapat
    MichaelOrlov authored and roncapat committed Nov 6, 2023
    Configuration menu
    Copy the full SHA
    6b4c2bd View commit details
    Browse the repository at this point in the history

  44. Add qos serialization format auto-detection 

    Signed-off-by: Michael Orlov <michael.orlov@apex.ai>
    @MichaelOrlov @roncapat
    MichaelOrlov authored and roncapat committed Nov 6, 2023
    Configuration menu
    Copy the full SHA
    377d1e6 View commit details
    Browse the repository at this point in the history

  45. Workaround to properly convert offered_qos_profiles in mcap storage 

    - For old versions of the mcap files we were not storing metadata inside
mcap files and metadata.version was assigned to the default 9 version.

Signed-off-by: Michael Orlov <michael.orlov@apex.ai>
    @MichaelOrlov @roncapat
    MichaelOrlov authored and roncapat committed Nov 6, 2023
    Configuration menu
    Copy the full SHA
    cae07aa View commit details
    Browse the repository at this point in the history

  46. Fix clang format 

    Signed-off-by: Patrick Roncagliolo <ronca.pat@gmail.com>
    @roncapat
    roncapat committed Nov 6, 2023
    Configuration menu
    Copy the full SHA
    753e3e3 View commit details
    Browse the repository at this point in the history

  47. Last fixes 

    Signed-off-by: Patrick Roncagliolo <ronca.pat@gmail.com>
    @roncapat
    roncapat committed Nov 6, 2023
    Configuration menu
    Copy the full SHA
    dff7cdf View commit details
    Browse the repository at this point in the history

Commits on Nov 7, 2023

  1. Fix visibility 

    Signed-off-by: Patrick Roncagliolo <ronca.pat@gmail.com>
    @roncapat
    roncapat committed Nov 7, 2023
    Configuration menu
    Copy the full SHA
    de95fbb View commit details
    Browse the repository at this point in the history

  2. Uncrust 

    Signed-off-by: Patrick Roncagliolo <ronca.pat@gmail.com>
    @roncapat
    roncapat committed Nov 7, 2023
    Configuration menu
    Copy the full SHA
    3bcc025 View commit details
    Browse the repository at this point in the history

Commits on Nov 8, 2023

  1. Fix DLL troubles with yaml-cpp 

    Signed-off-by: Patrick Roncagliolo <ronca.pat@gmail.com>
    @roncapat
    roncapat committed Nov 8, 2023
    Configuration menu
    Copy the full SHA
    fc19114 View commit details
    Browse the repository at this point in the history

Commits on Nov 9, 2023

  1. Metadata V9 offered_qos_profiles as pure YAML 

    Signed-off-by: Patrick Roncagliolo <ronca.pat@gmail.com>
    @roncapat
    roncapat committed Nov 9, 2023
    Configuration menu
    Copy the full SHA
    39c453c View commit details
    Browse the repository at this point in the history