Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add default initialization for CompressionOptions #1539

Merged
merged 2 commits into from
Jan 20, 2024
Merged

Add default initialization for CompressionOptions #1539

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
9d2ae52
feat: add sane defaults for CompressionOptions
Jan 15, 2024
4de0d87
Update rosbag2_compression/include/rosbag2_compression/compression_op…
arneboe Jan 18, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions rosbag2_compression/include/rosbag2_compression/compression_options.hpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -58,11 +58,11 @@ ROSBAG2_COMPRESSION_PUBLIC std::string compression_mode_to_string(CompressionMod
*/
struct CompressionOptions
{
std::string compression_format;
CompressionMode compression_mode;
uint64_t compression_queue_size;
std::string compression_format{};
CompressionMode compression_mode{CompressionMode::NONE};
uint64_t compression_queue_size{0};
/// \brief // The number of compression threads
uint64_t compression_threads;
uint64_t compression_threads{0};
/// \brief If set, the compression thread(s) will try to set the given priority for itself
/// For Windows the valid values are: THREAD_PRIORITY_LOWEST, THREAD_PRIORITY_BELOW_NORMAL and
/// THREAD_PRIORITY_NORMAL. For POSIX compatible OSes this is the "nice" value.
Expand Down
Loading