Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add note about MCAP compression options to readme.md file #1588

Merged
merged 1 commit into from
Mar 22, 2024
Merged

Add note about MCAP compression options to readme.md file #1588

merged 1 commit into from
Mar 22, 2024

Conversation

Aposhian
Copy link
Contributor

Addresses #1533 in part.

@Aposhian Aposhian requested a review from a team as a code owner March 16, 2024 00:09
@Aposhian Aposhian requested review from gbiggs and jhdcs and removed request for a team March 16, 2024 00:09
MichaelOrlov
MichaelOrlov approved these changes Mar 19, 2024
View reviewed changes
Copy link
Contributor

@MichaelOrlov MichaelOrlov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Aposhian Thanks for this PR.
LGTM. However, will need to fix DCO in your commit.

  1. In your local branch, run: git rebase HEAD~1 --signoff
  2. Force push your changes to overwrite the branch: git push --force-with-lease origin mcap-compression-docs

@MichaelOrlov MichaelOrlov changed the title add note about MCAP compression Add note about MCAP compression options to readme.md file Mar 19, 2024
@Aposhian
add note about MCAP compression
bf16a62 
Signed-off-by: Adam Aposhian <adam.aposhian@fireflyautomatix.com>
@MichaelOrlov MichaelOrlov merged commit 3032800 into ros2:rolling Mar 22, 2024
13 of 14 checks passed
@Aposhian Aposhian deleted the mcap-compression-docs branch March 25, 2024 14:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MichaelOrlov MichaelOrlov MichaelOrlov approved these changes

@gbiggs gbiggs Awaiting requested review from gbiggs gbiggs is a code owner automatically assigned from ros2/tooling-reviewers

@jhdcs jhdcs Awaiting requested review from jhdcs jhdcs is a code owner automatically assigned from ros2/tooling-reviewers

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@Aposhian @MichaelOrlov