[Rolling] Release 0.29.0 #1791
[Rolling] Release 0.29.0 #1791
Conversation
ahcorde
requested review from
MichaelOrlov and
hidmic
and removed request for
a team
There was a problem hiding this comment.
@ahcorde Thanks for the release.
We usually don't include details from the squashed commits in the rst files.
The rationale for that is that it is too much details in which no one intereseted in. For instance
- Fix style divergence
- Apply suggestions from code review
Please remove them. Need to keep only PR title and link on it
|
@ahcorde Please rebase your branch on top of the latest rolling. We merged one PR today. |
ahcorde
force-pushed
the
ahcorde/rolling/release-0.28.1
branch
from
1815571
to
2cf7a60
Compare
There was a problem hiding this comment.
@ahcorde Updates in changelog files looks good.
However, I think we should bump the major version for this release label. i.e. 0.29.0
Because we have breaking API/ABI changes in the following PRs:
Also, I don't see a valid tag ("0.28.1" or new "0.29.0") to be created in the rosbag2 repo.
ahcorde
force-pushed
the
ahcorde/rolling/release-0.28.1
branch
from
2cf7a60
to
e685e5f
Compare
There was a problem hiding this comment.
@ahcorde Thanks for the quick fixes for the major release number changes.
Overall, it looks good. I will tentatively approve.
However, I am worried about a weird RPR job failure.
And need to fix DCO.
Please make sure that 0.29.0 tag is pointing to the correct hash after fixing DCO.
If there is only option to squash and merge after approval in github, it will be better to do squash manually. Since after squashing the tag will be pointing to the non existent commit. Will need to fix tag before merging to rolling.
|
@ros-pull-request-builder retest this please |
ahcorde
force-pushed
the
ahcorde/rolling/release-0.28.1
branch
from
ef27fb8
to
1ec8f4f
Compare
Once this is approved, I'll squash merge it onto
rolling, add the 0.28.1 tag, and bloom-release it.