Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve SQLite error messages #269

Merged
merged 1 commit into from
Jan 31, 2020
Merged

Improve SQLite error messages #269

merged 1 commit into from
Jan 31, 2020

Conversation

zmichaels11
Copy link
Contributor

@zmichaels11 zmichaels11 commented Jan 27, 2020 •
edited
Loading

Changes

Karsten1987
Karsten1987 approved these changes Jan 28, 2020
View reviewed changes
Copy link
Collaborator

@Karsten1987 Karsten1987 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm with green CI

@zmichaels11
Copy link
Contributor Author

@ros2/aws-oncall - please run this CI job
Gist: https://gist.githubusercontent.com/zmichaels11/0b77f4b557748dee5d858ddf2f8b4aed/raw/1a21cb6d88de6c80e9ed1e7de02b5d8cae48ea20/ros2.repos
BUILD args: --packages-up-to rosbag2_storage_default_plugins rosbag2_tests
TEST args: --packages-select rosbag2_storage_default_plugins rosbag2_tests
Job: ci_launcher

@zmichaels11
Copy link
Contributor Author

  • Linux Build Status
  • Linux-aarch64 Build Status
  • macOS Build Status
  • Windows Build Status

thomas-moulard
thomas-moulard approved these changes Jan 29, 2020
View reviewed changes
Copy link
Contributor

@thomas-moulard thomas-moulard left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@zmichaels11 zmichaels11 mentioned this pull request Jan 31, 2020
Closed
piraka9011
piraka9011 approved these changes Jan 31, 2020
View reviewed changes
Copy link
Contributor

@piraka9011 piraka9011 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

@zmichaels11
Improve SQLite error messages
fbaa5fe 
Signed-off-by: Zachary Michaels <zmichaels11@gmail.com>
@zmichaels11 zmichaels11 force-pushed the zmichaels11/enable-sqlite3-extended-result-codes branch from c288fc7 to fbaa5fe Compare January 31, 2020 18:34
@zmichaels11
Copy link
Contributor Author

zmichaels11 commented Jan 31, 2020 •
edited
Loading

Rebased onto master, going to rerun CI.
Same parameters as before.

Edit:

  • Linux Build Status
  • Linux-aarch64 Build Status
  • macOS Build Status
  • Windows Build Status

@zmichaels11 zmichaels11 merged commit c349100 into ros2:master Jan 31, 2020
@zmichaels11 zmichaels11 deleted the zmichaels11/enable-sqlite3-extended-result-codes branch January 31, 2020 19:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@thomas-moulard thomas-moulard thomas-moulard approved these changes

@Karsten1987 Karsten1987 Karsten1987 approved these changes

@piraka9011 piraka9011 piraka9011 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@zmichaels11 @thomas-moulard @Karsten1987 @piraka9011