Include utility to quiet cpplint.

[clalancette]

Signed-off-by: Chris Lalancette clalancette@openrobotics.org

This should fix the nightlies: https://ci.ros2.org/view/nightly/job/nightly_linux-aarch64_debug/1578/testReport/junit/rosbag2_py/cpplint/build_include_what_you_use__4____home_jenkins_agent_workspace_nightly_linux_aarch64_debug_ws_src_ros2_rosbag2_rosbag2_py_src_rosbag2_py__transport_cpp_123_/

[clalancette]

CI:

• Linux
• Linux-aarch64
• macOS
• Windows

[Karsten1987]

strange that we didn't catch this earlier. Thanks for the fix.

[emersonknapp]

strange that we didn't catch this earlier

It's not that strange - the linter versions aren't pinned and have broken out from underneath us numerous times before. Or can even have different behavior between development installs and buildfarm installs - since according to the official setup instructions, one environment might install from apt and one might install from pip - giving even different major versions.

[emersonknapp]

But also - maybe we weren't running it every time... #745

Rant stands, but that wasn't what the problem actually was this time ;P. We must have accidentally let through a yellow CI run PR at some point in there

[clalancette]

It's not that strange - the linter versions aren't pinned and have broken out from underneath us numerous times before. Or can even have different behavior between development installs and buildfarm installs - since according to the official setup instructions, one environment might install from apt and one might install from pip - giving even different major versions.

I understand your frustration with that, and share it to some degree. But even if we were to make this consistent between the buildfarm and CI jobs on Linux, for instance, there would still inevitably be drift between it and macOS and Windows. You could talk about pinning all of them to the lowest-common-denominator, but that has problems of its own. Anyway, that is a bit off-topic here.

Rant stands, but that wasn't what the problem actually was this time ;P. We must have accidentally let through a yellow CI run PR at some point in there

Cool, thanks for fixing that up!