Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Expose play_next() API via service #767

Merged
merged 1 commit into from
May 13, 2021
Merged

Expose play_next() API via service #767

merged 1 commit into from
May 13, 2021

Conversation

MichaelOrlov
Copy link
Contributor

@MichaelOrlov MichaelOrlov commented May 11, 2021 •
edited
Loading

Expose play_next() API via service

Part of the #696

Update: Rebased on top of master

@MichaelOrlov MichaelOrlov changed the title Expose play_next API via service Expose play_next() API via service May 11, 2021
@MichaelOrlov MichaelOrlov marked this pull request as ready for review May 11, 2021 09:04
@MichaelOrlov MichaelOrlov requested a review from a team as a code owner May 11, 2021 09:04
@MichaelOrlov MichaelOrlov requested review from Karsten1987, zmichaels11 and emersonknapp and removed request for a team May 11, 2021 09:04
@MichaelOrlov
Expose play_next service
4ae992e 
Signed-off-by: Michael Orlov <morlovmr@gmail.com>
@MichaelOrlov MichaelOrlov force-pushed the michaelorlov/expose_play_next_service branch from 2410d3e to 4ae992e Compare May 13, 2021 02:55
@MichaelOrlov
Copy link
Contributor Author

@emersonknapp @Karsten1987 This PR has been rebased and ready for review. Could you please review it?

emersonknapp
emersonknapp approved these changes May 13, 2021
View reviewed changes
Copy link
Collaborator

@emersonknapp emersonknapp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM (pending green CI)

@MichaelOrlov
Copy link
Contributor Author

Gist: https://gist.githubusercontent.com/MichaelOrlov/f8bedf19fb7c6c26c69c23b57ac8390c/raw/4cca7fb73daad8b19efd1e80e129cc33b83c237b/ros2.repos

BUILD args: --packages-up-to rosbag2_transport
TEST args: --packages-select rosbag2_transport
Job: ci_launcher
ci_launcher ran: https://ci.ros2.org/job/ci_launcher/8461/

  • Linux Build Status
  • Linux-aarch64 Build Status
  • macOS Build Status
  • Windows Build Status

@MichaelOrlov MichaelOrlov merged commit 7143558 into ros2:master May 13, 2021
@MichaelOrlov MichaelOrlov mentioned this pull request Jun 2, 2021
Closed
50 tasks
@Kaju-Bubanja Kaju-Bubanja mentioned this pull request Jul 5, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@emersonknapp emersonknapp emersonknapp approved these changes

@Karsten1987 Karsten1987 Awaiting requested review from Karsten1987

@zmichaels11 zmichaels11 Awaiting requested review from zmichaels11

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@MichaelOrlov @emersonknapp