Started working on jump service feature #810
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I would like to implement Expose jump services on the Player from #696. I checked how it was done for the set_rate service #767, but the whole package is quite complex and I'm not sure how rosbag2_cpp interacts with rosbag2_transport. I'm not sure if one can be seen as the backend and the other as the frontend and if I should expose the jump service in rosbag2_transport, like the others or if it should reside in rosbag2_cpp like I did now. I currently can't get it to build, but before investing more time, I would be thankful for some advice, if this is the correct package to add the service.