Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Expect EXIT_FAILURE when storage id is not present #45

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Expect EXIT_FAILURE when storage id is not present #45

wants to merge 1 commit into from

Conversation

Karsten1987
Copy link
Contributor

as per title

@Karsten1987 Karsten1987 requested a review from a team as a code owner May 19, 2021 01:06
@Karsten1987 Karsten1987 requested review from jaisontj and prajakta-gokhale and removed request for a team May 19, 2021 01:06
@Karsten1987 Karsten1987 mentioned this pull request May 19, 2021
Merged
@emersonknapp
Copy link
Contributor

Based on the title of this test - maybe it should also be EXPECT_NO_THROW?

@MichaelOrlov
Copy link

@Karsten1987 Am I understand correctly that rational for this changes is the same as I have described in ros2/rosbag2#763?

If so, it looks like we need to change the test name as well. We are not handling exceptions and not exiting gracefully anymore.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@emersonknapp emersonknapp emersonknapp approved these changes

@jaisontj jaisontj Awaiting requested review from jaisontj

@prajakta-gokhale prajakta-gokhale Awaiting requested review from prajakta-gokhale

Assignees
No one assigned
Labels
backlog
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@Karsten1987 @emersonknapp @MichaelOrlov @clalancette