use latin-1 encoding when reading/writing .idl files, prepend BOM to generated C/C++ files when necessary #391
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dirk-thomas
added
bug
dirk-thomas
added
in progress
sloretz
previously approved these changes
Jul 19, 2019
dirk-thomas
force-pushed
the
dirk-thomas/bom-generated-code
branch
from
fc12331
to
c758b12
Compare
dirk-thomas
added
in review
|
After all the issues in the pipeline have been addressed the second commit in this PR fixes the actual problem from #388 and prepends a BOM to generated C/C++ if necessary: |
sloretz
reviewed
Jul 19, 2019
sloretz
approved these changes
Jul 19, 2019
Signed-off-by: Dirk Thomas <dirk-thomas@users.noreply.github.com>
Signed-off-by: Dirk Thomas <dirk-thomas@users.noreply.github.com>
dirk-thomas
force-pushed
the
dirk-thomas/bom-generated-code
branch
from
2697181
to
18f022b
Compare
Signed-off-by: Dirk Thomas <dirk-thomas@users.noreply.github.com>
dirk-thomas
changed the title
dirk-thomas
changed the title
skucheria
pushed a commit
that referenced
this pull request
Aug 2, 2019
…generated C/C++ files when necessary (#391) * use utf-8 encoding when reading/writing expanded templates Signed-off-by: Dirk Thomas <dirk-thomas@users.noreply.github.com> * inject BOM into generated C/C++ code when necessary Signed-off-by: Dirk Thomas <dirk-thomas@users.noreply.github.com> * use latin-1 encoding for .idl files Signed-off-by: Dirk Thomas <dirk-thomas@users.noreply.github.com> Signed-off-by: Siddharth Kucheria <kucheria@usc.edu>
skucheria
pushed a commit
that referenced
this pull request
Aug 2, 2019
…generated C/C++ files when necessary (#391) * use utf-8 encoding when reading/writing expanded templates Signed-off-by: Dirk Thomas <dirk-thomas@users.noreply.github.com> * inject BOM into generated C/C++ code when necessary Signed-off-by: Dirk Thomas <dirk-thomas@users.noreply.github.com> * use latin-1 encoding for .idl files Signed-off-by: Dirk Thomas <dirk-thomas@users.noreply.github.com> Signed-off-by: Siddharth Kucheria <kucheria@usc.edu>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addresses the problem on Windows related to ros2/test_interface_files#8.