Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix error msg asserts due to change in pytest #393

Merged
merged 1 commit into from
Jul 24, 2019

Conversation

wjwwood
Copy link
Member

@wjwwood wjwwood commented Jul 23, 2019

This is causing failures on nightly, but overlapped with fixes for the connect pr so I rolled them together.

Connects to ros2/launch#277

Signed-off-by: William Woodall <william@osrfoundation.org>
@wjwwood wjwwood added bug Something isn't working in review Waiting for review (Kanban column) labels Jul 23, 2019
@wjwwood wjwwood self-assigned this Jul 23, 2019
@wjwwood wjwwood merged commit b86d78a into master Jul 24, 2019
@delete-merged-branch delete-merged-branch bot deleted the revert-276-revert-265-emulate_tty branch July 24, 2019 21:54
@jacobperron
Copy link
Member

Looks like this should be backported to Dashing (see test failures: ros2/ros2#754 (comment)).

@nuclearsandwich nuclearsandwich added this to Proposed in Dashing Patch Release 3 via automation Aug 6, 2019
@nuclearsandwich nuclearsandwich moved this from Proposed to Needs Backport in Dashing Patch Release 3 Aug 6, 2019
wjwwood added a commit that referenced this pull request Sep 5, 2019
Signed-off-by: William Woodall <william@osrfoundation.org>
wjwwood added a commit that referenced this pull request Sep 6, 2019
Signed-off-by: William Woodall <william@osrfoundation.org>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working in review Waiting for review (Kanban column)
Projects
No open projects
Development

Successfully merging this pull request may close these issues.

None yet

3 participants