Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Backport of #393 to dashing #407

Merged
merged 1 commit into from
Sep 6, 2019
Merged

Backport of #393 to dashing #407

merged 1 commit into from
Sep 6, 2019

Conversation

wjwwood
Copy link
Member

@wjwwood wjwwood commented Sep 5, 2019

Backport of #393 to dashing, needed as noted here: #393 (comment)

@wjwwood
fix error msg asserts due to change in pytest (#393)
ee97160 
Signed-off-by: William Woodall <william@osrfoundation.org>
@wjwwood wjwwood added the in review Waiting for review (Kanban column) label Sep 5, 2019
@wjwwood wjwwood self-assigned this Sep 5, 2019
@wjwwood
Copy link
Member Author

wjwwood commented Sep 5, 2019

CI (full, this branch, dashing repos file):

  • Linux Build Status
  • Linux-aarch64 Build Status
  • macOS Build Status
  • Windows Build Status

nuclearsandwich
nuclearsandwich approved these changes Sep 5, 2019
View reviewed changes
Copy link
Member

@nuclearsandwich nuclearsandwich left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM with passing CI. Fixing our tests on CI makes spotting actual issues with the releases much easier so when convenient I'm in favor of backporting test fixes.

@wjwwood
Copy link
Member Author

wjwwood commented Sep 5, 2019

CI is failing in rviz_rendering, what CI should I run, presuming that the dashing repo file is not compiling (my conclusion based on the fact that this patch shouldn't affect rviz_rendering). This is the error snippet:

13:01:56 CMake Error at CMakeLists.txt:42 (find_package):
13:01:56   By not providing "Findeigen3_cmake_module.cmake" in CMAKE_MODULE_PATH this
13:01:56   project has asked CMake to find a package configuration file provided by
13:01:56   "eigen3_cmake_module", but CMake did not find one.
13:01:56 
13:01:56   Could not find a package configuration file provided by
13:01:56   "eigen3_cmake_module" with any of the following names:
13:01:56 
13:01:56     eigen3_cmake_moduleConfig.cmake
13:01:56     eigen3_cmake_module-config.cmake
13:01:56 
13:01:56   Add the installation prefix of "eigen3_cmake_module" to CMAKE_PREFIX_PATH
13:01:56   or set "eigen3_cmake_module_DIR" to a directory containing one of the above
13:01:56   files.  If "eigen3_cmake_module" provides a separate development package or
13:01:56   SDK, be sure it has been installed.
13:01:56 
13:01:56 
13:01:56 -- Configuring incomplete, errors occurred!

The cause looks like something wrong with the patch on the dashing branch of rviz related to eigen? (ros2/rviz@7491f8e) @sloretz?

@sloretz sloretz mentioned this pull request Sep 5, 2019
Merged
@sloretz
Copy link
Contributor

sloretz commented Sep 5, 2019

The cause looks like something wrong with the patch on the dashing branch of rviz related to eigen? (ros2/rviz@7491f8e) @sloretz?

@wjwwood ros2/ros2#773 adds eigen3_cmake_module to the dashing repos file.

@wjwwood
Copy link
Member Author

wjwwood commented Sep 5, 2019

CI again (full - connext, this branch, dashing repos file):

  • Linux Build Status
  • Linux-aarch64 Build Status
  • macOS Build Status
  • Windows Build Status

@nuclearsandwich
Copy link
Member

nuclearsandwich commented Sep 6, 2019 •
edited
Loading

The flake8 in CI above don't block this backport IMO. Fixes for the affected repositories can be made if and when they ever need other fixes in Dashing.

@wjwwood wjwwood merged commit 00ba8a6 into dashing Sep 6, 2019
@wjwwood wjwwood deleted the backport_393 branch September 6, 2019 17:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nuclearsandwich nuclearsandwich nuclearsandwich approved these changes

Assignees

@wjwwood wjwwood

Labels
in review Waiting for review (Kanban column)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@wjwwood @sloretz @nuclearsandwich