avoid zero length comment when the comment only contains a unit #411
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Dirk Thomas <dirk-thomas@users.noreply.github.com>
jacobperron
approved these changes
Sep 10, 2019
delete-merged-branch
bot
deleted the
dirk-thomas/avoid-zero-length-comments
branch
|
@dirk-thomas, @jacobperron is it possible to backport this feature to Dashing? Thank you! |
jacobperron
pushed a commit
that referenced
this pull request
Oct 14, 2019
Signed-off-by: Dirk Thomas <dirk-thomas@users.noreply.github.com>
jacobperron
pushed a commit
that referenced
this pull request
Oct 15, 2019
Signed-off-by: Dirk Thomas <dirk-thomas@users.noreply.github.com>
nuclearsandwich
moved this from Needs Release
to Needs Backport
in Dashing Patch Release 4
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Notices while working on #410.
Not planning to run CI on this trivial swap.