Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

move non-entry point headers into detail subdir #461

Merged
merged 1 commit into from
Apr 16, 2020

Conversation

dirk-thomas
Copy link
Member

@dirk-thomas dirk-thomas commented Apr 14, 2020

Follow up of #446 and #447 moving the non-entry point headers into a subdirectory. Since we don't distinguish the directories anywhere based on the language (C or C++) but do so based on the file extension I kept all of the moved headers in a detail subdirectory.

  • Linux Build Status
  • Linux-aarch64 Build Status
  • macOS Build Status
  • Windows Build Status

Signed-off-by: Dirk Thomas <dirk-thomas@users.noreply.github.com>
@dirk-thomas dirk-thomas force-pushed the dirk-thomas/rosidl-detail-subdir branch from 836c154 to a241e57 Compare April 14, 2020 21:31
@dirk-thomas dirk-thomas added this to In review in Foxy API Freeze Apr 15, 2020
Copy link
Member

@jacobperron jacobperron left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM pending CI

@jacobperron
Copy link
Member

Please add an entry to the Foxy release notes regarding this change.

@dirk-thomas dirk-thomas merged commit 7b54fee into master Apr 16, 2020
@delete-merged-branch delete-merged-branch bot deleted the dirk-thomas/rosidl-detail-subdir branch April 16, 2020 19:46
@jacobperron jacobperron moved this from In review to Done in Foxy API Freeze Apr 16, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
No open projects
Development

Successfully merging this pull request may close these issues.

None yet

2 participants