Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

export targets in a addition to include directories / libraries #465

Merged
merged 1 commit into from Apr 20, 2020
Merged

export targets in a addition to include directories / libraries #465

merged 1 commit into from Apr 20, 2020

Conversation

dirk-thomas
Copy link
Member

Allowing modern CMake usage.

@dirk-thomas dirk-thomas self-assigned this Apr 17, 2020
@dirk-thomas
Copy link
Member Author

CI builds using only FastRTPS:

  • Linux Build Status
  • Linux-aarch64 Build Status
  • macOS Build Status
  • Windows Build Status

@dirk-thomas dirk-thomas added this to In review in Foxy API Freeze Apr 18, 2020
hidmic
hidmic approved these changes Apr 20, 2020
View reviewed changes
Copy link
Contributor

@hidmic hidmic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM though why mixing CMake and C/C++ documentation updates in the same commit?

rosidl_runtime_c/include/rosidl_runtime_c/primitives_sequence_functions.h Outdated Show resolved Hide resolved
rosidl_runtime_c/include/rosidl_runtime_c/primitives_sequence_functions.h Outdated Show resolved Hide resolved
@dirk-thomas
export targets in a addition to include directories / libraries
de49270 
Signed-off-by: Dirk Thomas <dirk-thomas@users.noreply.github.com>
@dirk-thomas
Copy link
Member Author

why mixing CMake and C/C++ documentation updates in the same commit?

Good catch. I accidentally used -a with other changes in the working copy. I removed the documentation related changes.

@dirk-thomas dirk-thomas merged commit 2ae6374 into master Apr 20, 2020
@delete-merged-branch delete-merged-branch bot deleted the dirk-thomas/export-targets branch April 20, 2020 16:33
@wjwwood wjwwood moved this from In review to Done in Foxy API Freeze Apr 20, 2020
@dirk-thomas
Copy link
Member Author

Related to ros2/ros2#904.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hidmic hidmic hidmic approved these changes

Assignees

@dirk-thomas dirk-thomas

Labels
None yet
Projects
No open projects
Foxy API Freeze
  
Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@dirk-thomas @hidmic