Use ASSERT_TRUE to check for nullptr. #543
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
clang static analysis reports this as a false positive for a possible memory leak. This is incorrect, but the FAQ for googletest also has this tidbit: https://github.com/google/googletest/blob/master/googletest/docs/faq.md#why-does-googletest-support-expect_eqnull-ptr-and-assert_eqnull-ptr-but-not-expect_nenull-ptr-and-assert_nenull-ptr Thus, just switch to ASSERT_TRUE for the check, which is good enough and makes clang static analysis happier. Signed-off-by: Chris Lalancette <clalancette@openrobotics.org>
|
CI:
|
sloretz
approved these changes
Nov 5, 2020
delete-merged-branch
bot
deleted the
clalancette/fix-test-nullptr-check
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
clang static analysis reports this as a false positive for
a possible memory leak. This is incorrect, but the FAQ
for googletest also has this tidbit:
https://github.com/google/googletest/blob/master/googletest/docs/faq.md#why-does-googletest-support-expect_eqnull-ptr-and-assert_eqnull-ptr-but-not-expect_nenull-ptr-and-assert_nenull-ptr
Thus, just switch to ASSERT_TRUE for the check, which is
good enough and makes clang static analysis happier.
Signed-off-by: Chris Lalancette clalancette@openrobotics.org