Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Treat \t as whitespace #557

Merged
merged 1 commit into from
Jan 5, 2021
Merged

Treat \t as whitespace #557

merged 1 commit into from
Jan 5, 2021

Conversation

dawonn
Copy link
Contributor

@dawonn dawonn commented Dec 21, 2020

Fixes #556.

clalancette
clalancette requested changes Dec 22, 2020
View reviewed changes
Copy link
Contributor

@clalancette clalancette left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Treating tabs as spaces seems reasonable enough to me. This change also seems OK.

Can you please add a test for this?

@clalancette clalancette mentioned this pull request Dec 23, 2020
Merged
@dawonn
Treat \t as whitespace
6a05e2d 
Signed-off-by: Dereck Wonnacott <dereck@gmail.com>
clalancette
clalancette approved these changes Jan 4, 2021
View reviewed changes
Copy link
Contributor

@clalancette clalancette left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems reasonable to me. I'll run CI on it next.

@clalancette
Copy link
Contributor

CI:

  • Linux Build Status
  • Linux-aarch64 Build Status
  • macOS Build Status
  • Windows Build Status

@clalancette
Copy link
Contributor

The failures on all platforms are known, so this looks good to go. Thanks for the contribution, merging.

@clalancette clalancette merged commit 71e7cff into ros2:master Jan 5, 2021
dawonn added a commit to dawonn/rosidl that referenced this pull request Feb 9, 2021
@dawonn
Treat \t as whitespace (ros2#557)
6bae09b 
Signed-off-by: Dereck Wonnacott <dereck@gmail.com>
clalancette pushed a commit that referenced this pull request Feb 26, 2021
@dawonn
Foxy backport hex constants and tab as whitespace support (#568)
952e485 
* Treat \t as whitespace (#557)

Signed-off-by: Dereck Wonnacott <dereck@gmail.com>

* Support hex constants in msg files (#559)

Signed-off-by: Dereck Wonnacott <dereck@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@clalancette clalancette clalancette approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

msg parser does not consider tabs as whitespace
2 participants
@dawonn @clalancette