Support flow style YAML printing. #613
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Michel Hidalgo <michel@ekumenlabs.com>
|
CI up to
|
sloretz
approved these changes
Aug 9, 2021
There was a problem hiding this comment.
LGTM. I think limiting style to a boolean is a good idea. Users wanting any styling beyond this can be encouraged to use a yaml emitting library rather than taking on that responsibility here.
|
Full CI (to be safe):
|
|
Alright, going in ! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #608. This patch:
to_yaml()overload in the message namespace taking anstd::ostreamreference and replaces it withto_block_style_yaml()andto_flow_style_yaml()functions.to_yaml()overload in the message namespace returning anstd::stringto switch to flow style (precluding the need for a new type to convey the chosen style, relying on the fact that only two YAML styles exist).We can discuss the API choices, I don't mind strongly about these.