Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add action2idl script #654

Merged
merged 2 commits into from
Jul 11, 2022
Merged

Add action2idl script #654

merged 2 commits into from
Jul 11, 2022

Conversation

Greek64
Copy link
Contributor

@Greek64 Greek64 commented Jan 29, 2022

Though the rosidl_adapter has scripts to generate IDL files from .msg and .srv files, a script for .action files is missing.
This PR rectifies that.

hidmic
hidmic reviewed Jan 31, 2022
View reviewed changes
Copy link
Contributor

@hidmic hidmic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Greek64 LGTM overall, but I will point out that in Galactic and onwards, you can also do rosidl translate --to idl path/to/my.action

rosidl_adapter/scripts/action2idl.py Outdated Show resolved Hide resolved
@Greek64
Copy link
Contributor Author

Greek64 commented Jan 31, 2022

@Greek64 LGTM overall, but I will point out that in Galactic and onwards, you can also do rosidl translate --to idl path/to/my.action

I didn't know that, thanks.
Is that documented anywhere?

@hidmic
Copy link
Contributor

hidmic commented Feb 17, 2022 •
edited
Loading

Is that documented anywhere?

ros2/design#310 is probably the best place. Arguably, it should be replicated here.

CI up to rosidl_adapter:

  • Linux Build Status
  • Linux-aarch64 Build Status
  • Windows Build Status

@hidmic
Copy link
Contributor

hidmic commented Apr 25, 2022

@Greek64 mind to alphabetise module import order? That should please flake8.

@Greek64
Add action2idl script
e8f812a 
Signed-off-by: Greek64 <greek64.mail@gmail.com>
@Greek64
Copy link
Contributor Author

Greek64 commented Apr 25, 2022

@hidmic Done.

@audrow audrow changed the base branch from master to rolling June 28, 2022 14:23
@sloretz
Copy link
Contributor

sloretz commented Jul 11, 2022

CI (repos file build: --packages-up-to rosidl_adapter test: --packages-select rosidl_adapter)

  • Linux Build Status
  • Linux-aarch64 Build Status
  • Windows Build Status

sloretz
sloretz approved these changes Jul 11, 2022
View reviewed changes
Copy link
Contributor

@sloretz sloretz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM with green CI

@sloretz
Copy link
Contributor

sloretz commented Jul 11, 2022

Thanks for the PR!

@sloretz sloretz merged commit 0250ae8 into ros2:rolling Jul 11, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hidmic hidmic hidmic left review comments

@sloretz sloretz sloretz approved these changes

Assignees

@hidmic hidmic

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@Greek64 @hidmic @sloretz