-
Notifications
You must be signed in to change notification settings - Fork 125
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add missing build_export_depend dependency #665
Conversation
Signed-off-by: Jorge Perez <jjperez@ekumenlabs.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could you explain a little more why you think this is the correct fix? Looking at the python code in here, there are no direct references to rosidl_runtime_cpp
. There are references to rosidl_runtime_cpp
in the tests, but that should be covered by the existing test_depend
. There are also references to rosidl_runtime_cpp
in the empy templates, which suggests to me that maybe this should be a build_export_depend
instead. @sloretz any thoughts?
@clalancette The lines of code generating this issue come from #660, in particular https://github.com/ros2/rosidl/blob/master/rosidl_generator_cpp/cmake/rosidl_generator_cpp_generate_interfaces.cmake#L119-L121 I wasn't sure if |
|
Signed-off-by: Jorge Perez <jjperez@ekumenlabs.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good with green CI, thanks!
Warnings not related to this PR, merging, thanks for the feedback! |
Follow up PR to #660.
This PR is failing in the cyclonedds jobs, starting from this one: https://build.ros2.org/view/Rci/job/Rci__nightly-cyclonedds_ubuntu_focal_amd64/608/
I'm not sure if this is exactly the cause of the problem, I'll run a couple of tests before removing draft mode into this PR.
FYI: @sloretz
Signed-off-by: Jorge Perez jjperez@ekumenlabs.com